GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — README.md: remove outdated Windows cache tip link by me-and · Pull Request #1042 · actions/cache

Conversation

@me-and

@me-and me-and commented Dec 24, 2022

Copy link
Copy Markdown
Contributor

Description

As of 9b0be58 (Release compression related changes for windows (#1039), 2022-12-23), the section of tips-and-workarounds.md referring to improving cache restore performance on Windows no longer exists, so don't link to it from README.md.

Motivation and Context

See above: this is a small change to README.md to remove a link that's no longer needed.

How Has This Been Tested?

  • GitHub Actions run of the test scripts at https://github.com/me-and/cache/actions/runs/3771529989
  • Visual check of the rendering at https://github.com/me-and/cache/tree/correct-readme-re-windows#known-practices-and-workarounds

Screenshots (if appropriate):

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@me-and
README.md: remove outdated Windows cache tip link
501277c 
As of 9b0be58 (Release compression related changes for windows (actions#1039),
2022-12-23), the section of tips-and-workarounds.md referring to
improving cache restore performance on Windows no longer exists, so
don't link to it from README.md.
@me-and
me-and requested a review from a team as a code owner December 24, 2022 13:26
@github-actions
github-actions Bot requested a review from tanuj077 December 24, 2022 13:26
@github-actions github-actions Bot assigned tanuj077 Dec 24, 2022
@kotewar
kotewar requested review from Phantsure and lvpx December 26, 2022 04:50
@lvpx
Merge branch 'main' into correct-readme-re-windows
3337563
lvpx
lvpx approved these changes Dec 26, 2022
View reviewed changes

@lvpx lvpx left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this issue @me-and.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lvpx
lvpx merged commit d1507cc into actions:main Dec 26, 2022
@mikelane mikelane mentioned this pull request Dec 28, 2022
Bump actions/cache from 3.2.1 to 3.2.2 mikelane/reddit-get#119
Merged
@Teddy-van-Jerry Teddy-van-Jerry mentioned this pull request Jan 3, 2023
Bump actions/cache from 3.2.1 to 3.2.2 mmcesim/mmcesim#16
Merged
@renovate renovate Bot mentioned this pull request Feb 20, 2023
fix(deps): update all non-major dependencies Blagues-API/blagues-api#478
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanuj077 tanuj077 Awaiting requested review from tanuj077
@Phantsure Phantsure Awaiting requested review from Phantsure
1 more reviewer
@lvpx lvpx lvpx approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tanuj077 tanuj077

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@me-and @lvpx @tanuj077
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.