GeezerVison is showing github.com — Revert compression changes related to windows but keep version logging by Phantsure · Pull Request #1049 · actions/cache
Conversation
Phantsure
commented
Dec 27, 2022
•
edited by lvpx
Loading
Uh oh!
There was an error while loading. Please reload this page.
due to symlink issues
Description
Revert compression changes related to windows but keep version logging
Motivation and Context
Some issues have been reported due to linux/mac cache not being recovered on windows because of symlink issue. We would be testing possible solutions for them till then reverting this change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to change)
- Documentation (add or update README or docs)
Checklist:
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- I have read the CONTRIBUTING document.
- I have added tests to cover my changes.
- All new and existing tests passed.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Dakshjain1
pushed a commit
to SvavaCapital/cache
that referenced
this pull request
Apr 19, 2024
actions#1049)
* Revert compression changes related to windows
due to symlink issues
* Added tips and workarounds for cross os
Reviewers
tanuj077
Awaiting requested review from tanuj077
1 more reviewer
lvpx
lvpx approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.