GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add SBT in cache managers. by fmeriaux · Pull Request #302 · actions/setup-java

Conversation

@fmeriaux

@fmeriaux fmeriaux commented Mar 24, 2022

Copy link
Copy Markdown

Description:
Describe your changes.

Add SBT cache manager.

Related issue:
Add link to the related issue.

#266 (comment)

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Florian Meriaux
Add SBT in cache managers.
754319f
@fmeriaux fmeriaux mentioned this pull request Mar 24, 2022
Integrate sbt into setup-java or create a new one called setup-sbt for better support for self-hosted runners 🚀 #266
Closed
@fmeriaux
fmeriaux marked this pull request as ready for review March 24, 2022 09:17
Florian Meriaux
Add sbt cache tests.
a618b3f
laughedelic
laughedelic reviewed Mar 24, 2022
View reviewed changes
Comment thread src/cache.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux added 2 commits March 24, 2022 14:24
Florian Meriaux
add sbt pattern.
acc6b27
Florian Meriaux
Update sbt pattern.
133446f
@dmitry-shibanov

dmitry-shibanov commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Hello @fmeriaux. Could you please sync with the main branch?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux
Merge branch 'actions:main' into sbt-cache
c08d2af
@fmeriaux
fmeriaux requested a review from a team April 4, 2022 13:00
@fmeriaux

fmeriaux commented Apr 4, 2022

Copy link
Copy Markdown
Author

Hello @fmeriaux. Could you please sync with the main branch?

Done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux and others added 3 commits April 4, 2022 16:40
Florian Meriaux
ci: fix errors.
6f75354
Florian Meriaux
Merge branch 'main' into sbt-cache
c50e6b0
Florian Meriaux
Update README.md
4e72968
@dmitry-shibanov

dmitry-shibanov commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

Hello @fmeriaux. Could you please add e2e tests for sbt ?

fmeriaux reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@fmeriaux

fmeriaux commented Apr 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dmitry-shibanov

dmitry-shibanov commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

I think it should be something similar to Gradle test.

fmeriaux reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux
add e2e for sbt.
7df4807
@fmeriaux

fmeriaux commented Apr 12, 2022

Copy link
Copy Markdown
Author

Hello @fmeriaux. Could you please add e2e tests for sbt ?

Yes, no problem, but can you detail a little more what I have to do?

I think it should be something similar to Gradle test.

Thanks, done !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Donnadam

Donnadam commented Apr 12, 2022 via email

Copy link
Copy Markdown
I am so sick of receiving Github emails from Subscribers 6 a day? How can I be attached to the thread when I unsubscribed after 5 days last year? Please delete my email ***@***.*** ***@***.***>* Donna Murdoch
…
On Tue, 12 Apr 2022, 4:50 pm Florian Meriaux, ***@***.***> wrote: Hello @fmeriaux <https://github.com/fmeriaux>. Could you please add e2e tests for sbt ? Yes, no problem, but can you detail a little more what I have to do? I think it should be something similar to Gradle <https://github.com/actions/setup-java/blob/main/.github/workflows/e2e-cache.yml#L18-L66> test. Thanks, done ! — Reply to this email directly, view it on GitHub <#302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVVEBHXVXZIALDGTVVEZIOTVEUMJXANCNFSM5RQPPSSQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux added 2 commits April 12, 2022 11:53
Florian Meriaux
fix e2e for sbt.
b9d25ec
Florian Meriaux
fix e2e for sbt.
68d967e
@fmeriaux

fmeriaux commented Apr 12, 2022

Copy link
Copy Markdown
Author

According to https://github.com/coursier/cache-action#path

Cache should use the default OS-dependent location.

PR is updated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Florian Meriaux added 2 commits April 12, 2022 14:44
Florian Meriaux
search sbt files in all directories.
ff4b9e7
Florian Meriaux
fix cache paths
cc7d3b7
dmitry-shibanov
dmitry-shibanov reviewed Apr 13, 2022
View reviewed changes
Comment thread src/cache.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

dmitry-shibanov
dmitry-shibanov approved these changes Apr 20, 2022
View reviewed changes
marko-zivic-93
marko-zivic-93 approved these changes Apr 20, 2022
View reviewed changes
@dmitry-shibanov
dmitry-shibanov merged commit 0ed94a5 into actions:main Apr 20, 2022
@fmeriaux
fmeriaux deleted the sbt-cache branch April 21, 2022 07:06
julienrf
julienrf reviewed May 23, 2022
View reviewed changes
Comment thread src/cache.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@fmeriaux fmeriaux mentioned this pull request May 25, 2022
sbt-cache: don't cache some files. #332
Merged
2 tasks
@armanbilge armanbilge mentioned this pull request Jun 13, 2022
Setup java cache typelevel/sbt-typelevel#300
Merged
julienrf added a commit to scalacenter/website that referenced this pull request Jun 28, 2022
@julienrf
Use actions/setup-java caching abilities
0535a28
The support of sbt caching has been implement recently in actions/setup-java#302 and actions/setup-java#332 by Florian Meriaux
@julienrf julienrf mentioned this pull request Jun 28, 2022
Use actions/setup-java caching abilities sbt/website#1088
Merged
dhpiggott added a commit to dhpiggott/helios that referenced this pull request Jul 16, 2022
@dhpiggott
Delegate dependency caching to actions/setup-java
a5d43b4
It has just gained support via
actions/setup-java#302. See also
https://github.com/actions/setup-java#caching-sbt-dependencies.
@dhpiggott dhpiggott mentioned this pull request Jul 16, 2022
Delegate dependency caching to actions/setup-java dhpiggott/helios#47
Merged
dhpiggott added a commit to dhpiggott/helios that referenced this pull request Jul 16, 2022
@dhpiggott
Delegate dependency caching to actions/setup-java
258e3cd
It has just gained support via
actions/setup-java#302. See also
https://github.com/actions/setup-java#caching-sbt-dependencies.

Also add type to spec in HeliosSpec.
dhpiggott added a commit to dhpiggott/helios that referenced this pull request Jul 16, 2022
@dhpiggott
Delegate dependency caching to actions/setup-java
2a633a4
It has just gained support via
actions/setup-java#302. See also
https://github.com/actions/setup-java#caching-sbt-dependencies.

Also add type to spec in HeliosSpec.
rtyley added a commit to guardian/prout that referenced this pull request Dec 11, 2022
@rtyley
Use setup-java support for sbt-caching
12eea96
https://github.com/actions/setup-java#caching-sbt-dependencies

See actions/setup-java#302 - it looks like the
sbt-caching functionality was informed by
https://github.com/coursier/cache-action (see
actions/setup-java#302 (comment) ),
so setup-java may now be the 'best' solution.
@rtyley rtyley mentioned this pull request Dec 11, 2022
Use setup-java support for sbt-caching guardian/prout#75
Merged
rtyley added a commit to guardian/prout that referenced this pull request Dec 11, 2022
@rtyley
Use setup-java support for sbt-caching
ac04e34
https://github.com/actions/setup-java#caching-sbt-dependencies

See actions/setup-java#302 - it looks like the
sbt-caching functionality was informed by
https://github.com/coursier/cache-action (see
actions/setup-java#302 (comment) ),
so setup-java may now be the 'best' solution.
@rtyley rtyley mentioned this pull request Aug 5, 2023
Modernise GitHub Action for CI guardian/facia-scala-client#293
Merged
rtyley added a commit to rtyley/setup-java that referenced this pull request Dec 6, 2023
@rtyley
Avoid sbt cache being invalidated for a library that is only incremen…
842deab
…ting it's own version

While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232).

This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.

As such, it would be great to exclude `version.sbt` files from the cache hash key.

Background: `cache: sbt` was orginally introduced with actions#302
@rtyley rtyley mentioned this pull request Dec 6, 2023
Avoid sbt cache being invalidated for a library that is only incrementing its own version #564
Closed
2 tasks
rtyley added a commit to rtyley/setup-java that referenced this pull request Dec 7, 2023
@rtyley
Avoid sbt cache being invalidated for a library that is only incremen…
1301108
…ting it's own version

While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232).

This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.

As such, it would be great to exclude `version.sbt` files from the cache hash key.

Background: `cache: sbt` was orginally introduced with actions#302
rtyley added a commit to rtyley/setup-java that referenced this pull request Dec 7, 2023
@rtyley
Avoid sbt cache being invalidated for a library that is only incremen…
f228ab5
…ting it's own version

While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232).

This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.

As such, it would be great to exclude `version.sbt` files from the cache hash key.

Background: `cache: sbt` was orginally introduced with actions#302
@rtyley rtyley mentioned this pull request Jan 18, 2024
Upgrade to Play v2.9, Scala 2.13, Java 11 guardian/atom-workshop#349
Merged
tdfacer pushed a commit to ifit/setup-java that referenced this pull request Oct 7, 2025
Florian Meriaux
Add SBT in cache managers. (actions#302)
4cec197
rtyley added a commit to rtyley/setup-java that referenced this pull request Jun 22, 2026
@rtyley
Avoid sbt cache being invalidated for a library that is only incremen…
cff686e
…ting it's own version

While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232).

This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.

As such, it would be great to exclude `version.sbt` files from the cache hash key.

Background: `cache: sbt` was orginally introduced with actions#302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@julienrf julienrf julienrf left review comments
@laughedelic laughedelic laughedelic left review comments
@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@fmeriaux @dmitry-shibanov @Donnadam @julienrf @laughedelic @marko-zivic-93
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.