GeezerVison

Hello @WtfJoke. Thank you for your pull request. I have some questions:

• Do Amazon Corretto binaries have unstable versions ?
• Do Amazon Corretto binaries have jre versions

Hi @dmitry-shibanov

I'll try to answer the questions :)

• Do Amazon Corretto binaries have unstable versions ?

Not that I know of (at least the json, doesnt provide anything and I didnt found anything else documented).

• Do Amazon Corretto binaries have jre versions

Not many, but they do (for example they provide jre 8 for windows)

Is there a particular reason for your question (in order for me to improve my pr in any way)?

Hello @WtfJoke. Thank you for your responses. Could you please add support for jre versions ?

Hi @dmitry-shibanov

jre versions are already supported, see this test case for example:

Or did I missunderstand you?

Thank you @WtfJoke. Could you please include this test case to e2e ?

Sure, I've included it in the e2e-versions workflow (they provide only jre releases currently for windows in version 8).

As a small bonus 🎈 I've also changed the version of job setup-java-custom-package-type to java version 17 (instead of 16), so temurin doesnt need to be excluded anymore as they provide JRE releases for LTS versions and we have some more tests 😄

Thank you.

Is there a way to test the unreleased version?

@btsteve
Yes there is, you can use my fork + branch in your worfklow like this (until it is merged):

jobs:  
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: Install JDK 11
        uses: WtfJoke/setup-java@addCorretto
        with:
          distribution: corretto
          java-version: 11

Or here the full workflow yaml, I've tested with

Hey @dmitry-shibanov
Just rebased the commits to the latest main and resolved the conflicts.
As I know that you are probably busy, I've just wanted to ask gentle if there is some kind of ETA when you review/merge this PR?

Thanks a bunch!

@WtfJoke: can I also install Corretto on a Windows agent (runs-on: windows-latest)? If so, can I somehow already test your changes in one of my GitHub Actions? Or do I need to wait until it is released?

@WtfJoke: can I also install Corretto on a Windows agent (runs-on: windows-latest)? If so, can I somehow already test your changes in one of my GitHub Actions? Or do I need to wait until it is released?

@mu88 Yes, its also possible in windows.
You can already test it by using WtfJoke/setup-java@addCorretto instead of actions/setup-java@v3

See the example (there is also a full workflow yaml linked) in the comment above (you just can replace ubuntu with windows as you've already have written):

#312 (comment)

If you still need help, feel free to post your workflow.

For what its worth I've been using @WtfJoke's fork for a while now and seems to be working great!

@dmitry-shibanov Is this good to merge? Is there anything in particular I should test?

Hello @WtfJoke. Could you please sync with the main ? I've tested your changes and it works as expected.

Hi @dmitry-shibanov
I've rebased my branch with the latest main and fixed the conflicts. Great that you were able to test it.

Looking forward for the merge/release 😄 🚀

Great work!

Does anyone have an example of how to use this now?

@aaiezza See https://github.com/actions/setup-java#usage