GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Chore: add more test cases for `no-sequences` by snitin315 · Pull Request #14579 · eslint/eslint

Conversation

@snitin315

@snitin315 snitin315 commented May 8, 2021

Copy link
Copy Markdown
Contributor

Prerequisites checklist

  • I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: - test

What changes did you make? (Give an overview)

Add more test cases.

Refs #14572

Is there anything you'd like reviewers to focus on?

No

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@snitin315
Chore: add more test cases for no-sequences
7061958
@eslint-github-bot eslint-github-bot Bot added the triage An ESLint team member will look at this issue soon label May 8, 2021
aladdin-add
aladdin-add approved these changes May 12, 2021
View reviewed changes
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels May 12, 2021
mdjermanovic
mdjermanovic approved these changes May 13, 2021
View reviewed changes

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdjermanovic
mdjermanovic merged commit 086c1d6 into eslint:master May 13, 2021
@snitin315
snitin315 deleted the test-no-seq branch May 13, 2021 09:15
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Nov 10, 2021
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes
@mdjermanovic mdjermanovic mdjermanovic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing rule Relates to ESLint's core rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@snitin315 @aladdin-add @mdjermanovic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.