GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — `register-hook-require` entry point by brettz9 · Pull Request #257 · evanw/node-source-map-support

Conversation

@brettz9

@brettz9 brettz9 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Provide a source-map-support/register-hook-require entry-point (fixes #239)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eyexpo-thomas, jonsadka, and bajtos reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@brettz9
Provide a source-map-support/register-hook-require entry-point (fixes
244a768
evanw#239)
@brettz9

brettz9 commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

Btw, off topic, but just a heads up that on my local machine (Mac) after a local npm i, none of the server-based tests worked in Firefox, and on Chrome the test at http://127.0.0.1:1337/ (running node server.js within /header-test) failed and caused the server script to exit with the following error:

fs.js:114
    throw err;
    ^

Error: ENOENT: no such file or directory, open 'script.map'
    at Object.openSync (fs.js:443:3)
    at Object.readFileSync (fs.js:343:35)
    at Server.<anonymous> (/Users/brett/node-source-map-support/header-test/server.js:27:18)
    at Server.emit (events.js:198:13)
    at parserOnIncoming (_http_server.js:677:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@eyexpo-thomas

eyexpo-thomas commented Nov 7, 2019

Copy link
Copy Markdown

@brettz9 What is the status of this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettz9

brettz9 commented Nov 7, 2019

Copy link
Copy Markdown
Contributor Author

I'm not a maintainer here, @eyexpo-thomas . @evanw ?

eyexpo-thomas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonsadka

jonsadka commented Apr 18, 2020

Copy link
Copy Markdown

Any chance this feature is still being worked on? Looks like this will help a handful of people with source map issues in nyc (istanbuljs/nyc#619)

Raynos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Raynos

Raynos commented Jan 5, 2021

Copy link
Copy Markdown

@LinusU this is a small & useful feature for supporting nyc.

It's related to istanbuljs/nyc#619 (comment)

Currently i fix the stacktraces with source maps on nyc by editing my test suite.

With this feature merged & released instead I could do

nyc -a -r html -- node --require source-map-support/register-hook-require test/index.js

Which means the code coverage tooling can have working stacktraces / source maps without editing the source code of my test suite.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Sep 5, 2021
Add @cspotcode/source-map-support/register-hook-require #298
Closed
Add @cspotcode/source-map-support/register-hook-require cspotcode/node-source-map-support#25
Merged
@TwitchBronBron

TwitchBronBron commented Nov 17, 2021

Copy link
Copy Markdown

@evanw any movement on reviewing/merging this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Raynos
Raynos approved these changes Nov 17, 2021
View reviewed changes
@LinusU
LinusU merged commit b2b82e0 into evanw:master Nov 19, 2021
@LinusU

LinusU commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

Sorry for the delay on this, released as 0.5.21

@brettz9 would you be able to submit a follow up PR that adds documentation for this to the readme? ❤️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brettz9

brettz9 commented Nov 19, 2021

Copy link
Copy Markdown
Contributor Author

@LinusU : I'm afraid I am not doing well health-wise these days, and this isn't fresh in my memory (and probably more submitted originally just to overcome a road block). Maybe you could ask on #239 ?

LinusU reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LinusU

LinusU commented Nov 19, 2021

Copy link
Copy Markdown
Collaborator

@brettz9 no worries, wish you all the best, take care of yourself!

brettz9 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LinusU LinusU mentioned this pull request Nov 19, 2021
Feature Request: Provide a source-map-support/register-hook-require entry-point. #239
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Raynos Raynos Raynos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Provide a source-map-support/register-hook-require entry-point.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@brettz9 @eyexpo-thomas @jonsadka @Raynos @TwitchBronBron @LinusU
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.