GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ♻️ REFACTOR: Move internal `Rule`/`Delimiter` to dataclass by chrisjsewell · Pull Request #211 · executablebooks/markdown-it-py

Conversation

@chrisjsewell

@chrisjsewell chrisjsewell commented Apr 14, 2022

Copy link
Copy Markdown
Member

In order to remove attr dependency

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrisjsewell
♻️ REFACTOR: Move internal Rule/Delimiter to dataclass
e82d06e 
In order to remove attr dependency
@codecov

codecov Bot commented Apr 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #211 (e82d06e) into master (063268b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          61       61           
  Lines        3242     3242           
=======================================
  Hits         3117     3117           
  Misses        125      125
Flag Coverage Δ
pytests 96.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/ruler.py 89.65% <100.00%> (ø)
markdown_it/rules_inline/state_inline.py 97.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063268b...e82d06e. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisjsewell
chrisjsewell merged commit ead951d into master Apr 14, 2022
@chrisjsewell
chrisjsewell deleted the dataclass-internal branch April 14, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@chrisjsewell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.