GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com β€” πŸ“š DOCS: Update the example by redstoneleo Β· Pull Request #229 Β· executablebooks/markdown-it-py

Conversation

@redstoneleo

@redstoneleo redstoneleo commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

It is a very bad idea to .disable('image') in the example , most newbies just copy the example to test, by .disable('image') causes unnecessary problem for them. I suffered the problem. So let's make a more user-friendly example.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@redstoneleo
updated the example
79155e0 
It is a very bad idea to `.disable('image')` in the example , most newbies just copy the example to test, by  `.disable('image')` causes unnecessary problem for them. I suffered the problem. So let's make a more user-friendly example.
@welcome

welcome Bot commented Jan 10, 2023

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! πŸ€—

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! πŸŽ‰
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisjsewell chrisjsewell changed the title updated the example πŸ“š DOCS: updated the example Feb 22, 2023
@chrisjsewell
Merge branch 'master' into master
0cb6556
@chrisjsewell chrisjsewell changed the title πŸ“š DOCS: updated the example πŸ“š DOCS: Update the example Feb 22, 2023
@codecov

codecov Bot commented Feb 22, 2023 β€’
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 96.08% // Head: 96.08% // No change to project coverage πŸ‘

Coverage data is based on head (7eb956b) compared to base (4670f0c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          62       62           
  Lines        3221     3221           
=======================================
  Hits         3095     3095           
  Misses        126      126
Flag Coverage Ξ”
pytests 96.08% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisjsewell
Merge branch 'master' into master
7eb956b
@chrisjsewell
chrisjsewell merged commit 2c93e0b into executablebooks:master Feb 22, 2023
@welcome

welcome Bot commented Feb 22, 2023

Copy link
Copy Markdown

Congrats on your first merged pull request in this project! πŸŽ‰
congrats

Thank you for contributing, we are very proud of you! ❀️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrisjsewell

chrisjsewell commented Feb 22, 2023

Copy link
Copy Markdown
Member

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@redstoneleo @chrisjsewell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 β€” GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800Γ—600. No cookies required.