GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't set `poller.fd` twice in `newFdPoller` by tklauser · Pull Request #406 · fsnotify/fsnotify

Conversation

@tklauser

@tklauser tklauser commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

In newEmptyPoller when creating the poller using newEmptyPoller(fd), the
fd field is already set. There is no need to set it again.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nshalman

nshalman commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

I thought the tests would run when I did that... 😕
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nshalman

nshalman commented Jan 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@tklauser could you rebase your commit and force push to replace my merge commit to see if that will trigger the tests?
EDIT: It's related to #415. I'll push forward on that first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tklauser
Don't set poller.fd twice in newFdPoller
7193483 
In newEmptyPoller when creating the poller using newEmptyPoller(fd), the
fd field of the poller instance is already set. There is no need to set
it again.
@tklauser
tklauser force-pushed the poller-fd-set branch from 5fcbb4d to 7193483 Compare January 14, 2022 16:07
@nshalman
nshalman requested review from nshalman and shogo82148 January 16, 2022 01:26
nshalman
nshalman approved these changes Jan 16, 2022
View reviewed changes

@nshalman nshalman left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Being extra cautious and requesting @shogo82148 to confirm too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread inotify_poller.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nathany nathany added the linux label Jan 19, 2022
@nshalman
Merge branch 'main' into poller-fd-set
bfc212f
@nshalman

nshalman commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Having stared at this enough times and seeing the tests pass, I'm satisfied.
tklauser reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nshalman
nshalman merged commit 508ee5e into fsnotify:main Jan 19, 2022
@tklauser
tklauser deleted the poller-fd-set branch January 19, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shogo82148 shogo82148 Awaiting requested review from shogo82148
1 more reviewer
@nshalman nshalman nshalman approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tklauser @nshalman @nathany
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.