GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow build on unsupported GOOS by tklauser · Pull Request #424 · fsnotify/fsnotify

Conversation

@tklauser

@tklauser tklauser commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

In cases where fsnotify is a transitive dependency of a package, it
might need to be built on platforms not supported (yet), e.g. aix.
Provide an empty implemention for these cases, so depending packages
don't need to add workarounds.

Replaces #314

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
houndci-bot
houndci-bot reviewed Jan 24, 2022
View reviewed changes
Comment thread fsnotify_unsupported.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tklauser
Allow build on unsupported GOOS
d91abdd 
In cases where fsnotify is a transitive dependency of a package, it
might need to be built on platforms not supported (yet), e.g. aix.
Provide an empty implemention for these cases, so depending packages
don't need to add workarounds.

Replaces fsnotify#314
@tklauser
tklauser force-pushed the build-unsupported branch from db457e2 to d91abdd Compare January 24, 2022 10:24
@tklauser tklauser mentioned this pull request Jan 24, 2022
Create aix.go #314
Closed
sagikazarmark
sagikazarmark approved these changes Jan 24, 2022
View reviewed changes

@sagikazarmark sagikazarmark left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
nathany
nathany approved these changes Jan 25, 2022
View reviewed changes
@nathany
nathany merged commit bfa0135 into fsnotify:main Jan 25, 2022
@tklauser
tklauser deleted the build-unsupported branch January 25, 2022 08:04
@arp242 arp242 mentioned this pull request Jul 21, 2022
Fix build on Plan 9 #349
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@houndci-bot houndci-bot houndci-bot left review comments
@nathany nathany nathany approved these changes
@sagikazarmark sagikazarmark sagikazarmark approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tklauser @nathany @sagikazarmark @houndci-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.