GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support for other types of hooks · Issue #1762 · pre-commit/pre-commit

Support for other types of hooks #1762

New issue
Copy link
New issue
Copy link
Closed
Closed
Support for other types of hooks#1762
Copy link
Labels
featurequestion

Description

@psacawa
psacawa
opened on Jan 20, 2021
Issue body actions

Is there are reason why only some types of hooks are supported? I am interested in the post-merge hook that checks whether any documentation source files have been changed, and rebuilds them to html and prints them if they have. I would like to run it as a post-merge hook so it runs on git pull.

The documentation suggests this is not supported. Is there a workaround? Is there a technical obstruction to this use case?

Activity

  1. asottile commented on Jan 20, 2021

    @asottile
    asottile
    on Jan 20, 2021
    Member
    More actions

    nope! just needs someone to implement the other hooks. They've been implemented as needed

    if you want to try your hand at adding one, you might want to take a look at one of the others that's been implemented

    for example, here's the commit which added post-commit support: 26adf1d

  2. asottile
    added
    feature
    question
    on Jan 20, 2021
  3. psacawa commented on Jan 20, 2021

    @psacawa
    psacawa
    on Jan 20, 2021
    ContributorAuthor
    More actions

    This seems not hard, especially since post-merge is simple, so I'll try this.

  4. asottile commented on Feb 7, 2021

    @asottile
    asottile
    on Feb 7, 2021
    Member
    More actions

    @psacawa did you have a change to take a look at this?

  5. psacawa commented on Feb 7, 2021

    @psacawa
    psacawa
    on Feb 7, 2021
    ContributorAuthor
    More actions

    Yes, however I didn't create any tests, so I didn't submit a pr: 317ac63
    This is unfortunately low on my list of priorities. What's there is the easy part.

  6. asottile
    closed this as completedon Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featurequestion

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.