GeezerVison

GeezerVison is showing github.com — added recursive repository support for golang by paulhfischer · Pull Request #1789 · pre-commit/pre-commit

Conversation

paulhfischer commented Feb 6, 2021

Copy link

Copy Markdown

Contributor

resolves #1788

note that i also added depth=1 to reduce cache size and installation time. not sure if the whole command call should be replaced with _shallow_clone, depends on whether you want to keep all command calls within the helper module or not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

asottile commented Feb 6, 2021

Copy link

Copy Markdown

Member

oh :/ this was going to be my stream today -- this needs a test

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

paulhfischer commented Feb 6, 2021

Copy link

Copy Markdown

Contributor Author

oh i'm sorry :/

do you want to do this later today or shall i add a test?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asottile commented Feb 6, 2021

Copy link

Copy Markdown

Member

up to you -- the test is the actually interesting part of the patch. you might as well proceed

--depth actually doesn't matter here since that directory is ephemeral, though --reference might make it faster

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

paulhfischer and others added 2 commits

February 6, 2021 12:52


          added recursive repository support for golang

34e0ff3


          add test for recursive submodules for golang

833bbf7

asottile approved these changes

Feb 6, 2021

View reviewed changes

asottile left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests with --shared and --reference and --depth=1 and they didn't make a difference in the cloned size so I'm just going to stick to the easiest command here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

paulhfischer reacted with thumbs up emoji

All reactions

👍 1 reaction

asottile merged commit 2dac92c into pre-commit:master

Feb 6, 2021

paulhfischer deleted the recursive_golang branch

February 6, 2021 22:03

paulhfischer mentioned this pull request

Feb 15, 2021

updated pre-commit config and readme google/go-jsonnet#517

Merged

This was referenced Mar 8, 2021

Bump pre-commit from 2.7.1 to 2.11.0 GamePad64/hassio_wb_discovery#26

Closed

Bump pre-commit from 2.9.3 to 2.11.0 in /.github/workflows staticdev/cookiecutter-hypermodern-python#79

Closed

Bump pre-commit from 2.10.0 to 2.11.0 thermondo/stanley#818

Merged

Bump pre-commit from 2.7.1 to 2.11.0 in /bot emilfars/code-review#135

Closed

Bump pre-commit from 2.7.1 to 2.11.0 in /backend emilfars/code-review#136

Closed

Update pre-commit requirement from ~=2.10 to ~=2.11 CasperWA/push-protected#36

Closed

Update pre-commit requirement from ~=2.10 to ~=2.11 CasperWA/voila-optimade-client#272

Closed

Bump pre-commit from 2.6.0 to 2.11.0 rcmalli/faceless#87

Closed

Bump pre-commit from 2.9.3 to 2.11.0 materialsproject/reaction-network#13

Closed

Bump pre-commit from 2.7.1 to 2.11.0 wmalarski/music-reviews#50

Closed

Bump pre-commit from 2.7.1 to 2.11.0 bdraco/aiohttp#82

Closed

Bump pre-commit from 2.8.2 to 2.11.0 terencelimzhengwei/fitnessfirstsg#65

Closed

Bump pre-commit from 2.9.3 to 2.11.0 codustry/songmam#54

Closed

Bump pre-commit from 2.9.3 to 2.11.0 nathanrpage97/pytest-mutator#11

Closed

Update pre-commit requirement from ~=2.10 to ~=2.11 Materials-Consortia/providers-dashboard#32

Closed

Bump pre-commit from 2.9.3 to 2.11.0 TezRomacH/social-regexp#27

Closed

Bump pre-commit from 2.7.1 to 2.11.0 eranco74/assisted-test-infra#12

Closed

Bump pre-commit from 2.7.1 to 2.11.1 GamePad64/hassio_wb_discovery#27

Closed

Bump pre-commit from 2.9.3 to 2.11.1 in /.github/workflows staticdev/cookiecutter-hypermodern-python#80

Closed

Bump pre-commit from 2.6.0 to 2.11.1 rcmalli/faceless#90

Closed

Bump pre-commit from 2.7.1 to 2.11.1 wmalarski/music-reviews#51

Closed

This was referenced Mar 13, 2021

⬆️ Bump pre-commit from 2.10.0 to 2.11.1 jerr0328/isitsnowinginberlin#91

Merged

Bump pre-commit from 2.9.2 to 2.11.1 alerta/python-alerta-client#250

Closed

Bump pre-commit from 2.9.3 to 2.11.1 materialsproject/maggma#415

Closed

Bump pre-commit from 2.10.0 to 2.11.1 mozilla/task-boot#228

Closed

Bump pre-commit from 2.4.0 to 2.11.1 emceeaich/relman-auto-nag#52

Closed

Bump pre-commit from 2.6.0 to 2.11.1 ajacques/natlas#163

Closed

Bump pre-commit from 2.7.1 to 2.11.1 0xdade/natlas#177

Closed

build(deps-dev): bump pre-commit from 2.7.1 to 2.11.1 in /backend emilfars/code-review#141

Closed

build(deps-dev): bump pre-commit from 2.7.1 to 2.11.1 in /bot emilfars/code-review#143

Closed

Bump pre-commit from 2.9.2 to 2.11.1 tom-saunders/sqlitecaching#38

Closed

build(deps-dev): bump pre-commit from 2.10.0 to 2.11.1 in /backend marco-c/code-review#144

Closed

build(deps-dev): bump pre-commit from 2.10.0 to 2.11.1 in /bot marco-c/code-review#145

Closed

Bump pre-commit from 2.9.2 to 2.11.1 marco-c/mozci#61

Closed

Bump pre-commit from 2.9.2 to 2.11.1 ravisumit33/Mysterio#90

Closed

Bump pre-commit from 2.9.2 to 2.11.1 bgrins/bugbug#157

Closed

Bump pre-commit from 2.9.3 to 2.11.1 sacharya/assisted-test-infra#26

Closed

Bump pre-commit from 2.7.1 to 2.11.1 eranco74/assisted-test-infra#13

Closed

Bump pre-commit from 2.9.2 to 2.11.1 oshercc/assisted-test-infra#25

Closed

chore: bump pre-commit from 2.9.3 to 2.11.1 mvs-develop/dev.dna.works#14

Closed

Bump pre-commit from 2.10.0 to 2.11.1 jparrill/assisted-test-infra#23

Closed

Bump pre-commit from 2.9.3 to 2.11.1 rlopez133/assisted-test-infra#15

Closed

Bump pre-commit from 2.9.3 to 2.11.1 dmyersturnbull/suretime#15

Closed

Bump pre-commit from 2.9.3 to 2.11.1 materialsproject/reaction-network#16

Closed

Bump pre-commit from 2.10.0 to 2.11.1 marco-c/relman-auto-nag#16

Closed

Bump pre-commit from 2.9.3 to 2.11.1 hacf-fr/meteofrance-api#163

Merged

Bump pre-commit from 2.9.3 to 2.11.1 jmmshn/api#59

Closed

Bump pre-commit from 2.6.0 to 2.11.1 trussworks/circleci-docker-primary#185

Closed

Bump pre-commit from 2.8.2 to 2.11.1 janaSunrise/HypixelIO#10

Merged

Bump pre-commit from 2.8.2 to 2.11.1 hacf-fr/synologydsm-api#22

Merged

Bump pre-commit from 2.10.0 to 2.11.1 splunk/security_content#1258

Merged

Reviewers

asottile

asottile approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

recursive submodule support for language: golang

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.