GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for Go 1.16 by rafikdraoui · Pull Request #1818 · pre-commit/pre-commit

Conversation

@rafikdraoui

@rafikdraoui rafikdraoui commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Go 1.16 changes the way modules are handled. It now expects Go projects to have non-empty go.mod files.

This change is compatible with Go 1.15.

Fixes #1815


The golang tests pass under all combinations of Go [1.15|1.16] + GO111MODULE=[""|"on"|"auto"].

I could also install and run the following hook successfully with both Go 1.15 and Go 1.16:

- repo: local
    hooks:
      - id: shfmt
        name: Format shell files with shfmt
        language: golang
        additional_dependencies: ["mvdan.cc/sh/v3/cmd/[email protected]"]
        types: [shell]
        entry: shfmt -w

These changes work for my use cases, and they seem sensible to me, but I'm not all that familiar with Go modules, so perhaps this has some implications I don't know about.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rafikdraoui
Add support for Go 1.16
fe1f56c
Go 1.16 changes the way modules are handled. It now expects Go projects
to have non-empty `go.mod` files.

This change is compatible with Go 1.15.

Fixes #1815
asottile
asottile approved these changes Feb 27, 2021
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated that this is the only reasonable fix -- even setting the remote properly does not convince go that it should build

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@asottile
asottile merged commit a38f8d0 into pre-commit:master Feb 27, 2021
@rafikdraoui
rafikdraoui deleted the go1.16-support branch February 27, 2021 15:10
This was referenced Mar 8, 2021
Bump pre-commit from 2.7.1 to 2.11.0 GamePad64/hassio_wb_discovery#26
Closed
Bump pre-commit from 2.9.3 to 2.11.0 in /.github/workflows staticdev/cookiecutter-hypermodern-python#79
Closed
Bump pre-commit from 2.10.1 to 2.11.0 g-ongenae/litterature-mashup-bot#63
Closed
Bump pre-commit from 2.10.0 to 2.11.0 thermondo/stanley#818
Merged
Bump pre-commit from 2.10.1 to 2.11.0 staticdev/irpf-cei#378
Merged
Bump pre-commit from 2.10.1 to 2.11.0 natlas/natlas#686
Merged
Bump pre-commit from 2.7.1 to 2.11.0 in /bot emilfars/code-review#135
Closed
Bump pre-commit from 2.7.1 to 2.11.0 in /backend emilfars/code-review#136
Closed
Update pre-commit requirement from ~=2.10 to ~=2.11 CasperWA/push-protected#36
Closed
Update pre-commit requirement from ~=2.10 to ~=2.11 CasperWA/voila-optimade-client#272
Closed
Bump pre-commit from 2.10.1 to 2.11.0 staticdev/git-portfolio#311
Merged
Bump pre-commit from 2.10.1 to 2.11.0 yevgeny-shnaidman/assisted-test-infra#51
Closed
Bump pre-commit from 2.10.1 to 2.11.0 WeblateOrg/customize-example#36
Merged
Bump pre-commit from 2.10.1 to 2.11.0 WeblateOrg/helm#71
Merged
Bump pre-commit from 2.6.0 to 2.11.0 rcmalli/faceless#87
Closed
Bump pre-commit from 2.9.3 to 2.11.0 materialsproject/reaction-network#13
Closed
Bump pre-commit from 2.7.1 to 2.11.0 wmalarski/music-reviews#50
Closed
Bump pre-commit from 2.7.1 to 2.11.0 bdraco/aiohttp#82
Closed
Bump pre-commit from 2.8.2 to 2.11.0 terencelimzhengwei/fitnessfirstsg#65
Closed
Bump pre-commit from 2.9.3 to 2.11.0 codustry/songmam#54
Closed
Bump pre-commit from 2.9.3 to 2.11.0 nathanrpage97/pytest-mutator#11
Closed
Bump pre-commit from 2.10.1 to 2.11.0 sthagen/translate-translate#44
Closed
Bump pre-commit from 2.10.1 to 2.11.0 kumaraditya303/umarkdown#38
Closed
Bump pre-commit from 2.10.1 to 2.11.0 k3-cat/olea#18
Closed
Update pre-commit requirement from ~=2.10 to ~=2.11 Materials-Consortia/providers-dashboard#32
Closed
Bump pre-commit from 2.9.3 to 2.11.0 TezRomacH/social-regexp#27
Closed
This was referenced Mar 15, 2021
build(deps-dev): bump pre-commit from 2.10.0 to 2.11.1 in /backend marco-c/code-review#144
Closed
build(deps-dev): bump pre-commit from 2.10.0 to 2.11.1 in /bot marco-c/code-review#145
Closed
Bump pre-commit from 2.9.2 to 2.11.1 marco-c/mozci#61
Closed
Bump pre-commit from 2.10.1 to 2.11.1 rollandf/assisted-test-infra#56
Closed
Bump pre-commit from 2.10.1 to 2.11.1 yevgeny-shnaidman/assisted-test-infra#54
Closed
Bump pre-commit from 2.10.1 to 2.11.1 Jorgen1040/jassa-bot#35
Merged
Bump pre-commit from 2.10.1 to 2.11.1 frangiz/worktimer#17
Merged
Bump pre-commit from 2.9.2 to 2.11.1 ravisumit33/Mysterio#90
Closed
Bump pre-commit from 2.9.2 to 2.11.1 bgrins/bugbug#157
Closed
Bump pre-commit from 2.9.3 to 2.11.1 sacharya/assisted-test-infra#26
Closed
Bump pre-commit from 2.10.1 to 2.11.1 ConnectionMaster/bugbug#82
Closed
Bump pre-commit from 2.7.1 to 2.11.1 eranco74/assisted-test-infra#13
Closed
Bump pre-commit from 2.9.2 to 2.11.1 oshercc/assisted-test-infra#25
Closed
Bump pre-commit from 2.10.1 to 2.11.1 dmyersturnbull/typed-dfs#17
Closed
chore: bump pre-commit from 2.9.3 to 2.11.1 mvs-develop/dev.dna.works#14
Closed
Bump pre-commit from 2.10.0 to 2.11.1 jparrill/assisted-test-infra#23
Closed
Bump pre-commit from 2.9.3 to 2.11.1 rlopez133/assisted-test-infra#15
Closed
Bump pre-commit from 2.9.3 to 2.11.1 dmyersturnbull/suretime#15
Closed
Bump pre-commit from 2.9.3 to 2.11.1 materialsproject/reaction-network#16
Closed
Bump pre-commit from 2.10.0 to 2.11.1 marco-c/relman-auto-nag#16
Closed
Bump pre-commit from 2.10.1 to 2.11.1 frangiz/picorg#5
Merged
build(deps-dev): bump pre-commit from 2.10.1 to 2.11.1 lyz-code/mkdocs-newsletter#7
Closed
Bump pre-commit from 2.9.3 to 2.11.1 hacf-fr/meteofrance-api#163
Merged
Bump pre-commit from 2.9.3 to 2.11.1 jmmshn/api#59
Closed
Bump pre-commit from 2.10.1 to 2.11.1 hacf-fr/renault-api#224
Merged
Bump pre-commit from 2.6.0 to 2.11.1 trussworks/circleci-docker-primary#185
Closed
Bump pre-commit from 2.10.1 to 2.11.1 trussworks/docker-circleci#15
Merged
Bump pre-commit from 2.8.2 to 2.11.1 janaSunrise/HypixelIO#10
Merged
Bump pre-commit from 2.8.2 to 2.11.1 hacf-fr/synologydsm-api#22
Merged
Bump pre-commit from 2.10.0 to 2.11.1 splunk/security_content#1258
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Go 1.16

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rafikdraoui @asottile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.