GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix some -Wunused-parameter warnings by georgthegreat · Pull Request #8053 · protocolbuffers/protobuf

Conversation

@georgthegreat

@georgthegreat georgthegreat commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

With every release new unused parameters appear in the codebase (the previous one was fixed in #7878).

@acozzette, is there any option to ensure the absence of such parameters via CI / testing?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@georgthegreat
Fix some -Wunused-parameter warnings
9fef064
@google-cla google-cla Bot added the cla: yes label Nov 17, 2020
@acozzette acozzette added c++ release notes: yes labels Nov 17, 2020
@protobuf-kokoro protobuf-kokoro removed the kokoro:run label Nov 17, 2020
@acozzette
acozzette merged commit 0321358 into protocolbuffers:master Nov 17, 2020
@acozzette

acozzette commented Nov 17, 2020

Copy link
Copy Markdown
Collaborator

@georgthegreat Thanks for the fix. We could potentially change this line to CXXFLAGS="-Werror=unused-parameter" ./configure to make this an error, but I tried it just now and it won't build successfully without fixing other cases in protoc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@georgthegreat
georgthegreat deleted the fix-unused branch November 18, 2020 07:15
@georgthegreat georgthegreat mentioned this pull request Nov 18, 2020
Bundled googletest does not work with python3 #8055
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@georgthegreat @acozzette @protobuf-kokoro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.