GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Regexp deprecated third argument with Regexp::NOENCODING by weizheheng · Pull Request #1998 · rack/rack

Conversation

@weizheheng

@weizheheng weizheheng commented Dec 26, 2022

Copy link
Copy Markdown

Just upgraded to Ruby 3.2.0 and started seeing this deprecated warning message in my tests.

CleanShot 2022-12-26 at 12 05 33@2x

Related:

  • On Ruby issue tracker
    • Third argument to Regexp.new is a bit broken
  • PR that added that deprecated message

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

yuki24 and mishina2228 reacted with thumbs up emoji yuki24 reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 👀 1 reaction
Wei Zhe Heng @ioquatix
Fix Regexp deprecated third argument with Regexp::NOENCODING
7877a35
@ioquatix
ioquatix force-pushed the fix-regexp-deprecated-third-argument branch from 6f5267f to 7877a35 Compare December 26, 2022 11:41
ioquatix
ioquatix approved these changes Dec 26, 2022
View reviewed changes

@ioquatix ioquatix left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ioquatix
ioquatix merged commit 717e0e3 into rack:main Dec 26, 2022
ioquatix pushed a commit that referenced this pull request Dec 26, 2022
Wei Zhe @ioquatix
Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
d269711
ioquatix pushed a commit that referenced this pull request Dec 26, 2022
Wei Zhe @ioquatix
Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
ac892ab
@ioquatix ioquatix modified the milestones: v2.2.5, v3.0.3 Dec 26, 2022
@ioquatix

ioquatix commented Dec 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was released in v2.2.5 and v3.0.3.

dentarg and mishina2228 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ioquatix ioquatix self-assigned this Dec 26, 2022
@ioquatix ioquatix added the Maintenance label Dec 26, 2022
tnir added a commit to rubygems/bundler-site that referenced this pull request Jan 1, 2023
@tnir
Update rack from 2.2.4 to 2.2.5
0ab9e28
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <[email protected]>
@tnir tnir mentioned this pull request Jan 1, 2023
Update rack from 2.2.4 to 2.2.5 rubygems/bundler-site#1011
Merged
tnir added a commit to rubygems/bundler-site that referenced this pull request Jan 1, 2023
@tnir
Update rack from 2.2.4 to 2.2.5 (#1011)
c4f06f4
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <[email protected]>
@cvx cvx mentioned this pull request Jan 2, 2023
Build(deps): Bump rack from 2.2.4 to 2.2.5 discourse/discourse#19628
Merged
purecodecoach added a commit to purecodecoach/bundler-site that referenced this pull request Jan 13, 2023
@purecodecoach
Update rack from 2.2.4 to 2.2.5 (#1011)
3b5dd45
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <[email protected]>
tenderlove added a commit that referenced this pull request Jan 17, 2023
@tenderlove
Merge branch '3-0-sec'
becbf4b
* 3-0-sec: (24 commits)
  bump version
  Update changelog
  Fix ReDoS vulnerability in multipart parser
  Fix ReDoS in Rack::Utils.get_byte_ranges
  Forbid control characters in attributes
  Bump patch version.
  `Rack::Request#POST` should consistently raise errors. (#2010)
  Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007)
  Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006)
  Bump patch version.
  Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
  Update tests to work on latest Rubies. (#1999)
  Bump patch version.
  Allow passing through streaming bodies. (#1993)
  Remove unnecessary executable bit from test files (#1992)
  Fix Utils.build_nested_query to URL-encode all query string fields (#1989)
  Trim trailing white space throughout the project (#1990)
  Fix some typos (#1991)
  Remove leading dot to fix compatibility with latest cgi gem. (#1988)
  Fix outdated Rack::Builder rdocs and remove Lobster references (#1986)
  ...
@MSP-Greg MSP-Greg mentioned this pull request May 29, 2023
update URLMap Regexp usage for Ruby v3.3 puma/puma#3165
Merged
4 of 7 tasks
@TonyCTHsu TonyCTHsu mentioned this pull request Sep 14, 2023
Support Rack 3 by adding to test matrix DataDog/dd-trace-rb#3132
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioquatix ioquatix ioquatix approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ioquatix ioquatix

Labels

Maintenance

Projects

None yet

Milestone

v3.0.3

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@weizheheng @ioquatix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.