GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Keep the translation missing message when default is not nil by rafaelfranca · Pull Request #389 · ruby-i18n/i18n

Conversation

@rafaelfranca

@rafaelfranca rafaelfranca commented Oct 26, 2017

Copy link
Copy Markdown
Contributor

When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message.

Before this commit we were showing a translation missing error in the "no key" key.

This commit fixes a regression introduced in #387.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rafaelfranca rafaelfranca mentioned this pull request Oct 26, 2017
Fix default: nil with fallbacks #387
Merged
Edouard-chin
Edouard-chin approved these changes Oct 27, 2017
View reviewed changes
@radar

radar commented Nov 1, 2017

Copy link
Copy Markdown
Collaborator

Thank you @rafaelfranca and @Edouard-chin ❤️

This patch looks good to me. Could you please rebase this PR on top of the latest master? Master contains #390, which should fix some of your broken Travis tests (I hope 🤞 )

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca
rafaelfranca force-pushed the fix-default-regression branch from ad445f8 to 0efd34f Compare November 2, 2017 19:11
@rafaelfranca

rafaelfranca commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

Done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar

radar commented Nov 2, 2017

Copy link
Copy Markdown
Collaborator

Thanks! Travis is still broken though. Let me take a look... 🤔

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca

rafaelfranca commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

Looks related to Digest no being required. Maybe it was required by one of the files i18n require but now it is not anymore.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca @radar
Keep the translation missing message when default is not nil
4104295
When either the key and the all the defaults have missing translation we
should be showing the original key in the translation missing message.

Before this commit we were showing a translation missing error in the
"no key" key.

This commit fixes a regression introduced in ruby-i18n#387.
@radar
radar force-pushed the fix-default-regression branch from 0efd34f to 4104295 Compare November 2, 2017 23:46
@radar

radar commented Nov 2, 2017

Copy link
Copy Markdown
Collaborator

I've just rebased your branch on top of master. This should fix the Travis build and then we should be good to :shipit:!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca

rafaelfranca commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

Thanks! It is green now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar

radar commented Nov 3, 2017

Copy link
Copy Markdown
Collaborator

It sure is! ❤️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar
radar merged commit 86cc086 into ruby-i18n:master Nov 3, 2017
@radar

radar commented Nov 3, 2017

Copy link
Copy Markdown
Collaborator

v0.9.1 has just been released which contains this fix, as well as #390. Thank you for the attentiveness to this PR.

Edouard-chin reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca

rafaelfranca commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rafaelfranca
rafaelfranca deleted the fix-default-regression branch November 3, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Edouard-chin Edouard-chin Edouard-chin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rafaelfranca @radar @Edouard-chin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402605 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.