GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Hash#slice behavior not to return a subclass instance by amatsuda · Pull Request #390 · ruby-i18n/i18n

Conversation

@amatsuda

@amatsuda amatsuda commented Oct 27, 2017

Copy link
Copy Markdown
Contributor

Hash#slice has been introduced to Ruby core Hash class in 2.5. ruby/ruby@6c50bdda

The Ruby core version of Class(Hash)#slice returns a new instance of Hash, not an instance of the subclass, respecting consistency with other existing Hash methods, e. g.

Class.new(Hash)[:a, 1, :b, 2].select { true }.class
#=> Hash

Class.new(Hash)[:a, 1, :b, 2].reject { false }.class
#=> Hash

This PR fixes the I18n original Hash#slice implementation to behave in the same way with that of Ruby 2.5+ simply by reverting 6f291c4.

I do understand @jimmycuadra's use case described in #250, but in such case, please consider overriding slice inside that particular Hash subclass, just as we're doing in Active Support's hash_with_indifferent_access.rb.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@amatsuda
Revert "Maintain subclasses of Hash when calling Hash#slice."
a3257e4
This reverts commit 6f291c4.

This I18n original Hash#slice implementation behaves differently from that of Ruby 2.5+
@radar

radar commented Nov 1, 2017

Copy link
Copy Markdown
Collaborator

Thank you @amatsuda! I prefer your suggestion for an alternative fix to #250. Thank you for including that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar
radar merged commit 329ba05 into ruby-i18n:master Nov 1, 2017
@radar radar mentioned this pull request Nov 1, 2017
Keep the translation missing message when default is not nil #389
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@amatsuda @radar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402605 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.