GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't store translations for locales not set as available by stereobooster · Pull Request #391 · ruby-i18n/i18n

Conversation

@stereobooster

@stereobooster stereobooster commented Nov 3, 2017

Copy link
Copy Markdown
Contributor

rebased version of #261

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chipairon @stereobooster
Don't store translations for locales not set as available
5077ef9
@radar radar mentioned this pull request Nov 8, 2017
Don't store translations for locales not set as available with I18n#available_locales= #261
Closed
radar
radar requested changes Nov 8, 2017
View reviewed changes

@radar radar left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and then I think this is good to go. Thanks for rebasing it!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread lib/i18n/backend/simple.rb Outdated
# level of the hash.
def store_translations(locale, data, options = {})
if I18n.available_locales_initialized? &&
I18n.available_locales.include?(locale.to_sym) == false &&

@radar radar Nov 8, 2017

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use !I18n.available_locales.include?(locale.to_sym) here instead of == false.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@stereobooster
Fix CR notes
2b09acb
@stereobooster

stereobooster commented Nov 8, 2017

Copy link
Copy Markdown
Contributor Author

@radar updated PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

radar
radar approved these changes Nov 9, 2017
View reviewed changes
@radar

radar commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

LGTM! Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar
radar merged commit 4e9b237 into ruby-i18n:master Nov 9, 2017
@stereobooster stereobooster mentioned this pull request Nov 9, 2017
Fix anonymous objects #393
Merged
@tagliala tagliala mentioned this pull request Jan 27, 2018
Tests fail with i18n version 0.9.3 faker-ruby/faker#1132
Closed
tagliala added a commit to tagliala/faker that referenced this pull request Jan 27, 2018
@tagliala
Fix I18n 0.9.3 compatibility
a8e0a6c
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
@tagliala tagliala mentioned this pull request Jan 27, 2018
Fix I18n 0.9.3 compatibility faker-ruby/faker#1133
Merged
@clemens clemens mentioned this pull request Jan 27, 2018
Regression in 0.9.3 #404
Closed
mshibuya added a commit to carrierwaveuploader/carrierwave that referenced this pull request Feb 10, 2018
@mshibuya
Fix build failures caused by i18n
374ce35
I18n.available_locales needs to be cleared before storing translations: ruby-i18n/i18n#391
@wjordan wjordan mentioned this pull request Feb 13, 2018
store translations for unavailable locales if enforce_available_locales is false #408
Merged
tagliala added a commit to tagliala/faker that referenced this pull request May 20, 2018
@tagliala
Fix I18n 0.9.3 compatibility
df6e565
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
tagliala added a commit to tagliala/faker that referenced this pull request Jun 21, 2018
@tagliala
Fix I18n 0.9.3 compatibility
455db79
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
stympy pushed a commit to faker-ruby/faker that referenced this pull request Jun 21, 2018
@tagliala @stympy
Fix I18n 0.9.3 compatibility (#1133)
b5e25b1
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available.

This change set locales as available before storing translations.

Fix: #1132

Ref: ruby-i18n/i18n#391
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@tagliala @stympy
Fix I18n 0.9.3 compatibility (faker-ruby#1133)
cc04a36
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
@stereobooster
stereobooster deleted the dont-store-tr-for-locales-not-set-as-available branch December 15, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radar radar radar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@stereobooster @radar @chipairon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402605 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.