GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Interpolate for arrays by stereobooster · Pull Request #395 · ruby-i18n/i18n

Conversation

@stereobooster

@stereobooster stereobooster commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

rebased #282

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Bartuz and others added 6 commits November 9, 2017 15:47
Bartuz @stereobooster
Interpolate now works for array
2a5dd85
Filip Bartuzi @stereobooster
Update interpolation.rb
321bc1b
removes unnecessary line
@Bartuz @stereobooster
Refactor interpolation method
ae859dd
Suggested by @clemens
@Bartuz @stereobooster
Add comments exaplining new array behaviour for #interpolate
23069aa
@Bartuz @stereobooster
Fix specs for array interpolation
80e27e9
It covers full use case now.
Thankfully to #282 (comment)
@Bartuz @stereobooster
Remove redundant test for lookup
7ffc496
This reverts PART of commit ee27f3d.
thanks @clemens
https://github.com/svenfuchs/i18n/pull/282/files#r37780129
@stereobooster stereobooster closed this Nov 15, 2017
@radar

radar commented Nov 15, 2017

Copy link
Copy Markdown
Collaborator

Why do all that work and then close it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@stereobooster

stereobooster commented Nov 15, 2017

Copy link
Copy Markdown
Contributor Author

I have more interest in merging other my PRs. And gem supporters clearly have limited resources to support project. Decided on my priorities.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar

radar commented Nov 15, 2017 via email

Copy link
Copy Markdown
Collaborator
You close an non-priority PR after barely 6 days? I just don’t understand the rationale for this at all. Seems like a waste of work.
…
On 16 Nov 2017, at 06:39, stereobooster ***@***.***> wrote: I have more interest in merging other my PRs. And gem supporters clearly have limited resources to support project. Decided on my priorities. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar radar mentioned this pull request Nov 18, 2017
Interpolate now works for an array #282
Closed
@radar radar reopened this Nov 19, 2017
@radar

radar commented Nov 19, 2017

Copy link
Copy Markdown
Collaborator

Re-opening because there is interest in #282.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar

radar commented Nov 19, 2017

Copy link
Copy Markdown
Collaborator

#396 is now closed, so this can be closed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar radar closed this Nov 19, 2017
@fatkodima

fatkodima commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

#396 is now closed, so this can be closed.

Am I missing the relationship between this PR and that PR? Looks like they are not related and it would be great to get this merged.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radar radar reopened this Jan 18, 2018
radar
radar approved these changes Jan 19, 2018
View reviewed changes
@radar
radar merged commit c16460e into ruby-i18n:master Jan 19, 2018
@radar

radar commented Jan 19, 2018

Copy link
Copy Markdown
Collaborator

Yes, sorry. That was a typo on my end. Thanks @stereobooster and @fatkodima.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@stereobooster
stereobooster deleted the interpolate-for-arrays branch December 15, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radar radar radar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@stereobooster @radar @fatkodima @Bartuz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402605 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.