GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — Allow overriding of entry resolving entry resolving separate from defaults by movermeyer · Pull Request #622 · ruby-i18n/i18n Conversation
Contributor
What are you trying to accomplish?Fixes #617. Alternative to #620. #591 was incorrect, since I didn't check/realize that
Prior to #591, there was no distinction between the cases. #591 should have introduced that distinction. What approach did you choose and why?I added a I then changed the calls to What should reviewers focus on?🤷 The impact of these changesFixes #617. TestingI added the regression test from #620 to show that it works with the existing Rails calls.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
movermeyer
force-pushed
the
movermeyer/resolve_defaults_with_current_locale
branch
from
a5376cd to
19f190d
Compare
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [BUG] Fallbacks do not work for Rails STI modelsUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||
| You are visitor 01402605 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |