GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update AbstractObjectParser.java by 330233789 · Pull Request #119 · APIJSON/APIJSON

Conversation

@330233789

@330233789 330233789 commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

POST（新增）支持批量，批量事务问题处理方式：全部成功，则成功，只要一条失败，全部失败

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@330233789
Update AbstractObjectParser.java
8bd133f 
POST（新增）支持批量，批量事务问题处理方式：全部成功，则成功，只要一条失败，全部失败
@TommyLemon

TommyLemon commented Feb 26, 2020

Copy link
Copy Markdown
Member

非常感谢，里面有个小 bug 会导致编译不通过，具体见批注
https://github.com/APIJSON/APIJSON/pull/119/files#diff-5aac4eb3e72073f8c8dc00768d5d4f18
希望修复下哦
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@330233789
解决批量新增打包编译问题，完善git忽略文件
692c9fc
@TommyLemon
TommyLemon merged commit 1d2d25f into APIJSON:master Feb 27, 2020
TommyLemon
TommyLemon reviewed Feb 27, 2020
View reviewed changes

@TommyLemon TommyLemon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献，已合并，现在你也是 APIJSON 项目的一个 Contributer 了

image

https://github.com/TommyLemon/APIJSON/graphs/contributors

image

https://github.com/APIJSON/APIJSON/blob/master/README.md#%E8%B4%A1%E7%8C%AE%E8%80%85%E4%BB%AC

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread APIJSON-Java-Server/APIJSONORM/src/main/java/zuo/biao/apijson/server/AbstractObjectParser.java
}
}
else if (method == PUT && value instanceof JSONArray
} else if (value instanceof JSONArray && method == POST &&

@TommyLemon TommyLemon Feb 26, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST 未被 import 进来直接使用，编译报错

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread APIJSON-Java-Server/APIJSONORM/src/main/java/zuo/biao/apijson/server/AbstractObjectParser.java
JSONObject before = (JSONObject)response.get(key);
if(result.get("code").equals(200)){
if(before!=null){
before.put("count",before.getInteger("count")+result.getInteger("count"));

@TommyLemon TommyLemon Feb 26, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"count" 已有 JSONRequst.KEY_COUNT 常量，建议替换

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread APIJSON-Java-Server/APIJSONORM/src/main/java/zuo/biao/apijson/server/AbstractObjectParser.java
}
} else {
//只要有一条失败，则抛出异常，全部失败
throw new RuntimeException(key + "," + valueArray.getJSONObject(i) +",新增失败!");

@TommyLemon TommyLemon Feb 26, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议根据 JSONResponse.KEY_CODE 及 JSONResponse.KEY_MSG 改为更准确的 Exeption，方便排查错误

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@330233789
330233789 deleted the zhoulingfengofcd-patch-1 branch March 1, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TommyLemon TommyLemon TommyLemon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@330233789 @TommyLemon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.