GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix(logging): Replace printStackTrace() with proper logging by hobostay · Pull Request #850 · APIJSON/APIJSON

Conversation

hobostay commented Feb 17, 2026

Copy link

Copy Markdown

Contributor

Summary

Replace all e.printStackTrace() calls with Log.e() to follow best practices for error handling and logging.

Changes

This PR replaces all instances of e.printStackTrace() with proper logging using the project's Log.e() method, providing:

Consistent logging format with timestamps
Better error tracking in production environments
Controllable logging via Log.DEBUG flag
More meaningful error messages with context

Files Modified

AbstractSQLExecutor.java: 9 replacements (ResultSet close, transaction errors, connection close)
AbstractParser.java: 6 replacements (parse errors, transaction commit/rollback)
JSONRequest.java: 1 replacement (JSON parse error)
JSR223ScriptExecutor.java: 1 replacement (script compilation error)

Type

Bug Fix (improves error handling and debugging)
Feature
Refactoring
Documentation

Checklist

Tests pass locally
Follows project coding style
Self-review completed
Commit messages follow guidelines

Co-Authored-By: Claude Sonnet 4.5 [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TommyLemon reacted with thumbs up emoji

TommyLemon reacted with heart emoji

All reactions

👍 1 reaction
❤️ 1 reaction


          fix(logging): Replace printStackTrace() with proper logging

92cbf66

Replace all e.printStackTrace() calls with Log.e() to follow best
practices for error handling and logging. This provides:

- Consistent logging format with timestamps
- Better error tracking in production
- Ability to control logging via Log.DEBUG flag
- More meaningful error messages with context

Changes:
- AbstractSQLExecutor.java: 9 replacements
- AbstractParser.java: 6 replacements
- JSONRequest.java: 1 replacement
- JSR223ScriptExecutor.java: 1 replacement

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

TommyLemon merged commit 696af70 into APIJSON:master

Feb 18, 2026

1 check passed

Uh oh!

There was an error while loading. Please reload this page.

TommyLemon commented Feb 18, 2026

Copy link

Copy Markdown

Member

@hobostay
Thank you, especially when it's in spring festival.
Happy new year~

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.