GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — [DO NOT MERGE] DPL: run framework test through leaks on macos by aalkin · Pull Request #15955 · AliceO2Group/AliceO2 Conversation
Member
XCode provide a convenient command-line memory leak detection utility. This change wraps framework:core test with it. There is plenty of memory leaks which means the test fails, this PR will be used to monitor gradual fixing of the leaks.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
ktf
previously approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fine with me if passes the tests.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsMeta::name was a strdup'ed char const* that was never freed. Use std::string. Co-Authored-By: Claude Opus 5.5 <[email protected]> TestWSHandler stored strdup'ed copies of every frame and never freed them. Keep the frames in a std::vector<std::string> instead. Co-Authored-By: Claude Opus 5.5 <[email protected]> The buffers produced by encode_websocket_frames are malloc'ed and were never released. Free them at the end of each test block. Co-Authored-By: Claude Opus 5.5 <[email protected]> Request and frame inputs were strdup'ed and never freed. Use string_view on literals, make parse_http_request take char const*, and free the malloc'ed buffers. Co-Authored-By: Claude Opus 5.5 <[email protected]> The objects returned by the deserialization helpers were never deleted. Co-Authored-By: Claude Opus 5.5 <[email protected]> The inputs array allocated by the test was never released. Co-Authored-By: Claude Opus 5.5 <[email protected]>
aalkin
force-pushed
the
add-leaks-test-on-macos
branch
from
65aa13d to
7931f5e
Compare
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
aalkin
marked this pull request as draft
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
MilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. 3 participantsAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |