GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [AFIT-77] FDD reconstruction refactor by wpierozak · Pull Request #16042 · AliceO2Group/AliceO2

Conversation

@wpierozak

@wpierozak wpierozak commented Nov 3, 2026

Copy link
Copy Markdown
Contributor
  • Collision time calculation follows FT0 algorithm
  • Extended FDDRecoConfig structure with new collision time parameters and SW trigger parameters
  • Implemented SW VTX and OR trigger

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wpierozak
wpierozak requested review from afurs, andreasmolander, jotwinow and sahilupadhyaya92 as code owners November 3, 2026 15:12
@sahilupadhyaya92

sahilupadhyaya92 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @shahor02

This is an upcoming improvement (proposed, for now) for the FDD reconstruction.
I would like to ask, before merging it into the main branch, is it possible to get a test production, for example, for just 1 run ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shahor02

shahor02 commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @sahilupadhyaya92 ,

We cannot process on the grid w/o having a tag, I propose that you test it locally on small data to make sure it does not crash the processing and the result is what you would expect. Then we can merge it and ask @catalinristea to run a test production with a daily tag.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Wiktor Pierozak and others added 9 commits November 3, 2026 18:40
Wiktor Pierozak wpierozak
Draft of FDD reco refactor
1521406
Wiktor Pierozak wpierozak
draft
797b0e9
wpierozak wpierozak
Implemented FT0-like collision time calulcation for FDD. Prepared met…
ad6ce10 
…hods and data structure for SW trigger implementation
wpierozak wpierozak
Implemented SwTrigger bit in FDD recpoints, bumped RecPoints class ve…
5819a48 
…rsion to 4
wpierozak wpierozak
Fixed incorrect rounding to ns in collision time calculation; Fixed b…
33fa132 
…ug with number of entries counter
wpierozak wpierozak
Refactored parameters name; Preparing structure for coincidence checks
e716a5d
wpierozak wpierozak
Implemented coincidence mode; Renamed reco parameters
15a3914
wpierozak wpierozak
Fixed trigger bits assigment
580af2f
wpierozak wpierozak
clang-format
cf7ae55
@wpierozak
wpierozak force-pushed the AFIT-77 branch from 4f5c9e4 to cf7ae55 Compare November 3, 2026 17:40
Wiktor Pierozak
Refactored FDDRecoConfig - created enum DetectorSide, created amplitu…
79c8499 
…de threholds for A and C side
@alibuild alibuild mentioned this pull request Nov 12, 2026
Please consider the following formatting changes to #16042 wpierozak/AliceO2#13
Closed
@alibuild

alibuild commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 79c8499 at 2026-11-12 11:44:

## sw/BUILD/O2-latest/log
input_line_9:658:43: error: expected ';' after enum
Error: /sw/slc9_x86-64/ROOT/v6-36-10-alice4-6/bin/rootcling: compilation failure (/sw/BUILD/2ce16b52ada09eb50930e1c4d7db18ab55525d80/O2/DataFormats/Detectors/FIT/FDD/G__O2DataFormatsFDD7471430544_dictUmbrella.h)
CMake Error at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/cmake/RunRootcling.cmake:46 (message):
ninja: build stopped: subcommand failed.

Full log here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
wpierozak wpierozak
Implemented side-wise amplitude condition check in FDD reco
2abbcf4

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotwinow jotwinow Awaiting requested review from jotwinow jotwinow is a code owner
@afurs afurs Awaiting requested review from afurs afurs is a code owner
@andreasmolander andreasmolander Awaiting requested review from andreasmolander andreasmolander is a code owner
@sahilupadhyaya92 sahilupadhyaya92 Awaiting requested review from sahilupadhyaya92 sahilupadhyaya92 is a code owner

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@wpierozak @sahilupadhyaya92 @shahor02 @alibuild
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.