GeezerVison is showing github.com — Framework: key HIST() names by a fixed-string template argument by ktf · Pull Request #16045 · AliceO2Group/AliceO2
Conversation
HIST()/CONST_STR() created, at every call site, a lambda, a local struct, an
index_sequence expansion over the characters and a ConstStr<'a','b',...> type.
They now produce ConstStr<"ab">: one type per distinct name, the hash still a
static member computed once per name, and concatenation still at the type
level, so names passed as function parameters keep working. Hashes are
unchanged.
2,000 distinct names (a quarter concatenated with a directory) in a template
instantiated twice, -O2: clang 21 3.76 s -> 1.90 s and 591 -> 238 MB peak;
GCC 16 6.41 s -> 3.04 s and 602 -> 366 MB. Object size +6%.
Needs AliceO2Group/O2Physics#18584, which updates the helpers that spelled out
ConstStr<chars...>.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
HIST()/CONST_STR() created, at every call site, a lambda, a local struct, an
index_sequence expansion over the characters and a ConstStr<'a','b',...> type.
They now produce ConstStr<"ab">: one type per distinct name, the hash still a
static member computed once per name, and concatenation still at the type
level, so names passed as function parameters keep working. Hashes are
unchanged.
2,000 distinct names (a quarter concatenated with a directory) in a template
instantiated twice, -O2: clang 21 3.76 s -> 1.90 s and 591 -> 238 MB peak;
GCC 16 6.41 s -> 3.04 s and 602 -> 366 MB. Object size +6%.
Needs AliceO2Group/O2Physics#18584, which updates the helpers that spelled out
ConstStr<chars...>.
alibuild
commented
Nov 4, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Error while checking build/O2/fullCI_slc9 for 6fd6d9d at 2026-11-12 07:47:
## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowPtEfficiency.cxx:275:87: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowPtEfficiency.cxx:275:87: error: no matching function for call to 'FixedString(char)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowPtEfficiency.cxx:284:22: error: no matching function for call to 'o2::framework::HistogramRegistry::fill(const int&, const double&, double&, double&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:841:76: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:841:76: error: no matching function for call to 'FixedString(char)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:857:127: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:857:127: error: no matching function for call to 'FixedString(char)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:857:162: error: class template argument deduction failed:
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:857:162: error: no matching function for call to 'FixedString(char)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:850:22: error: no matching function for call to 'o2::framework::HistogramRegistry::fill(const int&, const double&, double&, double&)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:867:22: error: no matching function for call to 'o2::framework::HistogramRegistry::fill(const int&, const double&, double&, double)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:868:22: error: no matching function for call to 'o2::framework::HistogramRegistry::fill(const int&, const double&, double, double)'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/Flow/Tasks/flowTask.cxx:1571:22: error: no matching function for call to 'FlowTask::fillpTvnProfile(__gnu_cxx::__alloc_traits<std::allocator<GFW::CorrConfig>, GFW::CorrConfig>::value_type&, double&, double&, ConstStr<FixedString<15>{"c22_gap08_Weff"}>, ConstStr<FixedString<22>{"c22_gap08_trackMeanPt"}>, float&)'
ninja: build stopped: subcommand failed.
Full log here.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|