GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DPL Analysis: bind partitions without walking every task member by ktf · Pull Request #16049 · AliceO2Group/AliceO2

Conversation

@ktf

@ktf ktf commented Nov 4, 2026

Copy link
Copy Markdown
Member

invokeProcess walked all members of the task seven times per process
function to bind partitions and grouped combinations, instantiating the
binding lambdas for every member, although only those two kinds act on
them; for everything else the calls are empty overloads. Select the
partitions and combination generators once per task type, with a named
selector so that the full member walk is shared by all process
functions, and run the binding lambdas over those only. The calls that
do something happen in the same order as before.

StructToTuple gains apply_refs_tuple_cat_sized, a member walk whose
callable returns a tuple per member, concatenated into one.

Full -O2 compile, Apple clang 21, before -> after:

  • femtoUniverseProducerTask: 66.5 s -> 58.4 s (macro path, as for
    GCC 14), 67.6 s -> 58.7 s (structured binding packs)
  • dataCreatorCharmResoToDstarReduced: 44.6 s -> 41.7 s
  • derivedDataWriter: 79.9 s -> 74.8 s
    In femtoUniverseProducerTask the instantiation of the member walks goes
    from 5.9 s to 1.4 s.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ktf
DPL Analysis: bind partitions without walking every task member
a170050
invokeProcess walked all members of the task seven times per process
function to bind partitions and grouped combinations, instantiating the
binding lambdas for every member, although only those two kinds act on
them; for everything else the calls are empty overloads. Select the
partitions and combination generators once per task type, with a named
selector so that the full member walk is shared by all process
functions, and run the binding lambdas over those only. The calls that
do something happen in the same order as before.

StructToTuple gains apply_refs_tuple_cat_sized, a member walk whose
callable returns a tuple per member, concatenated into one.

Full -O2 compile, Apple clang 21, before -> after:
- femtoUniverseProducerTask: 66.5 s -> 58.4 s (macro path, as for
  GCC 14), 67.6 s -> 58.7 s (structured binding packs)
- dataCreatorCharmResoToDstarReduced: 44.6 s -> 41.7 s
- derivedDataWriter: 79.9 s -> 74.8 s
In femtoUniverseProducerTask the instantiation of the member walks goes
from 5.9 s to 1.4 s.
@ktf
ktf requested a review from a team as a code owner November 4, 2026 19:17
@ktf

ktf commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@aalkin apparently selecting the bindables upfront avoids instanciating the large types at each invokation (for some 5% speedup while building O2Physics).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aalkin

aalkin commented Nov 5, 2026

Copy link
Copy Markdown
Member

This is similar to what we have seen with the other pack operations, since it is always combinatorics. For iterating on the preselected tasks members and methods we need C++26 to properly fix this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ktf @aalkin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.