GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DPL Analysis: refactor origin level mapping (reworked) by aalkin · Pull Request #16086 · AliceO2Group/AliceO2

Conversation

@aalkin

@aalkin aalkin commented Nov 9, 2026

Copy link
Copy Markdown
Member

The standard behavior without origin level mapping is unaffected. When origin level mapping is used, the AOD metadata is taken from files on corresponding levels and propagated as per-origin labeled array to the devices in the workflow. For this, the metadata retrieval is refactored to only happen once in the driver, so that files are not re-opened later. The devices themselves, if they have origin replacement enabled, will modify their ConfigParamRegistry, replacing the standard aod-metadata- values there with the ones that conform to their origin, using the per-origin map that was passed to them via command line. This permits, for example, self-configuring tasks, such as event selection service, to be left as is - they will correctly get the metadata, corresponding to their replaced origin.

  • Re-add ConfigParamDiscovery test that was missing in the previous version

Replaces #15928.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
aalkin added 2 commits November 9, 2026 10:50
@aalkin
DPL Analysis: fix parent paths replacements
e93c43e
The AOD reader replaces every occurrence of the
aod-parent-base-path-replacement pattern in a parent file path, while
metadata discovery replaced only the first one, so the two could open
different files. Use the same replacement in both. An empty pattern is
now ignored, as it is in the reader.
@aalkin
Make AOD metadata discovery aware of the origin level mapping
b5ed7eb
With --aod-origin-replace and --aod-origin-level-mapping, every device
received the metadata of level 0, even when different files are read.
Each device now sees the metadata of the level its origin maps to.

- Parse and validate aod-origin-level-mapping once during discovery, into
  the aod-origin-level-map LabeledArray which the AOD reader now consumes.
- Read each mapped level through AODInputFile, opening every file in the
  chain of parents only once, and forward the result as the
  aod-metadata-origins LabeledArray and aod-metadata-origin-<O>-tables.
- Overlay the row of the origin of the process on the plain
  aod-metadata-* options at the end of discovery, erasing the keys which
  are missing at that level.
- Add LabeledArray::getRow by label, and tests for the above.

Without a mapping the plain options are unchanged.
@aalkin
aalkin requested a review from a team as a code owner November 9, 2026 09:54
@aalkin aalkin mentioned this pull request Nov 9, 2026
DPL Analysis: allow for per-origin AOD metadata handling #15928
Closed
@alibuild alibuild mentioned this pull request Nov 9, 2026
Please consider the following formatting changes to #16086 aalkin/AliceO2#159
Closed
@aalkin
format
2d0ffd2

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@aalkin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.