GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — TRD: additional selections for pile-up rejection in pulse height plots by glegras · Pull Request #16087 · AliceO2Group/AliceO2

Conversation

@glegras

@glegras glegras commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
glegras added 2 commits November 9, 2026 13:47
@glegras
TRD: additional pile-up selections
9ffc1b6
@glegras
clang format
3f7219a
@glegras
glegras requested review from bazinski, f3sch and wille10 as code owners November 9, 2026 12:51
@alibuild

alibuild commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 3f7219a at 2026-11-09 14:10:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat errors.txt
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TRD/calibration/src/PulseHeight.cxx:196:59: error: statement should be inside braces [readability-braces-around-statements,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glegras
fix
dd75628
bazinski
bazinski approved these changes Nov 12, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazinski bazinski bazinski approved these changes
@f3sch f3sch Awaiting requested review from f3sch f3sch is a code owner
@wille10 wille10 Awaiting requested review from wille10 wille10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@glegras @alibuild @bazinski
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.