GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GPU TPC clusterizer: wait for the gather of the previous sector before clearing the maps by ktf · Pull Request #16100 · AliceO2Group/AliceO2

Conversation

@ktf

@ktf ktf commented Nov 11, 2026

Copy link
Copy Markdown
Member

A lane reuses its scratch memory for its next sector. At the first
fragment the charge and peak maps were cleared without waiting for the
gather of the previous sector, which runs on another stream, and the maps
can overlap that sector's clusterByRow: on pbpb30 the peak map of sector 3
ends at row 0 of sector 0. When the gather starts late, row 0 of the
previous sector is gathered as zeros: on a 20 kHz Pb-Pb time frame on
Metal, the first run in a process found 0.42 % fewer sector tracks.

The existing wait on the gather sat on the clusterInRow clear, after the
map clears. Move it to the first map clear at fragment 0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ktf
GPU TPC clusterizer: wait for the gather of the previous sector befor…
33cc986
…e clearing the maps

A lane reuses its scratch memory for its next sector. At the first
fragment the charge and peak maps were cleared without waiting for the
gather of the previous sector, which runs on another stream, and the maps
can overlap that sector's clusterByRow: on pbpb30 the peak map of sector 3
ends at row 0 of sector 0. When the gather starts late, row 0 of the
previous sector is gathered as zeros: on a 20 kHz Pb-Pb time frame on
Metal, the first run in a process found 0.42 % fewer sector tracks.

The existing wait on the gather sat on the clusterInRow clear, after the
map clears. Move it to the first map clear at fragment 0.
@ktf
ktf requested a review from davidrohr as a code owner November 11, 2026 07:42
@ktf

ktf commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@davidrohr on metal this seems to be a genuine issue, with less tracks consistently missing when running on the 20 kHz reference data. Could you have a look if it makes sense?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davidrohr

davidrohr commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

I think the error is genuine, but I do not like the fix, since it adds synchronization and affects GPU performance. Interesting that I never saw this problem on AMD / NVIDIA. But that is the advantage of testing on different hardware :).
@fweig is in vacation, so I attempted a fix in #16103. Could you check if that works for you?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ktf

ktf commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Yours works and it's obviously better. Closing.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ktf ktf closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ktf @davidrohr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.