GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — GPU TPC clusterizer: wait for the gather of the previous sector before clearing the maps by ktf · Pull Request #16100 · AliceO2Group/AliceO2 Conversation
Member
A lane reuses its scratch memory for its next sector. At the first The existing wait on the gather sat on the clusterInRow clear, after the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…e clearing the maps A lane reuses its scratch memory for its next sector. At the first fragment the charge and peak maps were cleared without waiting for the gather of the previous sector, which runs on another stream, and the maps can overlap that sector's clusterByRow: on pbpb30 the peak map of sector 3 ends at row 0 of sector 0. When the gather starts late, row 0 of the previous sector is gathered as zeros: on a 20 kHz Pb-Pb time frame on Metal, the first run in a process found 0.42 % fewer sector tracks. The existing wait on the gather sat on the clusterInRow clear, after the map clears. Move it to the first map clear at fragment 0.
|
There was an error while loading. Please reload this page.
|
@davidrohr on metal this seems to be a genuine issue, with less tracks consistently missing when running on the 20 kHz reference data. Could you have a look if it makes sense? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I think the error is genuine, but I do not like the fix, since it adds synchronization and affects GPU performance. Interesting that I never saw this problem on AMD / NVIDIA. But that is the advantage of testing on different hardware :). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Yours works and it's obviously better. Closing. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.