GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Avoid InheritsFrom in CCDB object extraction by sawenzel · Pull Request #16115 · AliceO2Group/AliceO2

Conversation

@sawenzel

@sawenzel sawenzel commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

TClass::InheritsFrom("TObject") on an STL collection such as
std::vectoro2::detectors::AlignParam makes cling instantiate the class and
read a large part of the ROOT module data. IsTObject() gives the same answer
without this. In o2-sim, which fetches the alignment this way, this saves about
150 MB (16 workers, peak PSS 6384 -> 6215 MB) with bit-identical hits.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sawenzel
Avoid InheritsFrom in CCDB object extraction
532bd87 
TClass::InheritsFrom("TObject") on an STL collection such as
std::vector<o2::detectors::AlignParam> makes cling instantiate the class and
read a large part of the ROOT module data. IsTObject() gives the same answer
without this. In o2-sim, which fetches the alignment this way, this saves about
150 MB (16 workers, peak PSS 6384 -> 6215 MB) with bit-identical hits.
@sawenzel
sawenzel requested review from a team, Barthelemy and costing as code owners November 12, 2026 15:30
ktf
ktf approved these changes Nov 12, 2026
View reviewed changes
costing
costing approved these changes Nov 12, 2026
View reviewed changes

@costing costing left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Sandro, glad to hear that this saves so much memory!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ktf

ktf commented Nov 12, 2026

Copy link
Copy Markdown
Member

#16116 might help as well then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sawenzel
sawenzel merged commit bf2e035 into AliceO2Group:dev Nov 12, 2026
11 of 12 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sawenzel
sawenzel deleted the ccdb-istobject branch November 12, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktf ktf ktf approved these changes
@costing costing costing approved these changes
@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sawenzel @ktf @costing
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.