GeezerVison is showing github.com — [O2B-1545] Create GAQ summary tables by isaachilly · Pull Request #2173 · AliceO2Group/Bookkeeping
Conversation
isaachilly
commented
Jun 19, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
I have a JIRA ticket
- branch and/or PR name(s) include(s) JIRA ID
- issue has "Fix version" assigned
- issue "Status" is set to "In review"
- PR labels are selected
Notable changes for users:
Notable changes for developers:
Changes made to the database:
- New table to store GAQ summaries and if and when they are invalidated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add GaqSummaryRepository and GaqSummaryInvalidationRepository and export them from the repositories index.
Update migration to replace the previous invalidated_at field with created_at and add updated_at to mirror default Sequelize tables.
Rename and change mcReproducible to be the coverage float not the boolean.
Add a calculation_failed boolean column to gaq_summaries. This allows us to know whether a summary has been attempted to be calculated but unsuccessful due to limited data etc.
Remove not-null constraints from several GAQ summary columns in the migration to allow NULL when values are unavailable.
Store invalidation timestamp directly on gaq_summaries instead of a separate gaq_summary_invalidations table.
Create an index on invalidated_at column of gaq_summaries table to improve query performance, as it is commonly used to fetch the invalidated summary queue.
Sequelize model omitted the primaryKey that migration file defines.
codecov
Bot
commented
Jun 19, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.10%. Comparing base (838e6a8) to head (5fee0a4).
⚠️ Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
+ Coverage 45.82% 46.10% +0.28%
==========================================
Files 1039 1042 +3
Lines 17189 17201 +12
Branches 3138 3136 -2
==========================================
+ Hits 7877 7931 +54
+ Misses 9312 9270 -42 ☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Reviewers
graduta
Awaiting requested review from graduta
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.