GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] [QC-1206] Make CTP Scalers available to user code by Barthelemy · Pull Request #2522 · AliceO2Group/QualityControl

Conversation

@Barthelemy

@Barthelemy Barthelemy commented Mar 13, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Barthelemy added 5 commits March 13, 2025 14:10
@Barthelemy
[QC-1206] Make CTP Scalers available to user code
4a5244a
@Barthelemy
format
f020b14
@Barthelemy
disable CTP scalers in async
0f9b4d3
@Barthelemy
properly set the run number
166bb8a
@Barthelemy
doc
940a3be
@Barthelemy
Barthelemy requested review from justonedev1 and knopers8 as code owners March 13, 2025 13:14
@Barthelemy Barthelemy mentioned this pull request Mar 13, 2025
[WIP] [QC-1206] Make CTP Scalers available to user code #2460
Closed
Barthelemy added 4 commits March 13, 2025 14:15
@Barthelemy
format
9d1fe13
@Barthelemy
doc and cleanup
c23a052
@Barthelemy
put the scalers in their own class
344146e
@Barthelemy
form at
81fba10
justonedev1
justonedev1 approved these changes Mar 14, 2025
View reviewed changes

@justonedev1 justonedev1 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK, but if you want to review it properly maybe wait for Piotr.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Barthelemy added 2 commits March 14, 2025 14:09
@Barthelemy
change interface of UserCodeInterface to take the UserConfig (to ease…
7b442b4 
… future extension)
@Barthelemy
format
4bc18e9
@Barthelemy

Barthelemy commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator Author

@justonedev1 It is still in WIP as I am not completely done. I have to test it with Marian. And to test it is not trivial. I am trying to improve that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Barthelemy added 2 commits March 14, 2025 15:44
@Barthelemy
Possibility to set a different source repo for the scalers. Useful to…
e5b5898 
… test.
@Barthelemy
clean up and doc
6f9c473

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justonedev1 justonedev1 justonedev1 approved these changes
@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Barthelemy @justonedev1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.