GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [QC-353] External tasks' detector by Barthelemy · Pull Request #2702 · AliceO2Group/QualityControl

Conversation

@Barthelemy

@Barthelemy Barthelemy commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

We introduce a new parameter in the configuration of the external tasks: detectorName. Until now we used the query origin as heuristic.

It works but it introduces a number of changes that are not all very satisfactory IMO. In particular, we have to maintain a map with the external task detector names in the CheckRunner because the information is only present in the config and not in the received objects like for the normal MOs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Barthelemy
[QC-353] External tasks' detector
9a4803f 
We introduce a new parameter in the configuration of the external tasks: `detectorName`.
Until now we used the query origin as heuristic.

It works but it introduces a number of changes that are not all very satisfactory IMO.
In particular, we have to maintain a map with the external task detector names in the CheckRunner because the information is only present in the config and not in the received objects like for the normal MOs.
@Barthelemy
Barthelemy requested review from justonedev1 and knopers8 as code owners October 26, 2026 09:25
@Barthelemy

Barthelemy commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

@knopers8 What do you think ? did I miss a simpler way of achieving the same ? is it worth it ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Barthelemy Barthelemy changed the title [WIP] [QC-353] External tasks' detector [QC-353] External tasks' detector Oct 28, 2026
@knopers8

knopers8 commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Hmm, I don't quite remember what would be the use-case to set it to something else than origin. Do you remember perhaps? Indeed the number of changes is quite big for such a small feature.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Barthelemy

Barthelemy commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

No, I don't remember. It is a very old ticket. I am in favour of dropping the PR and closing the ticket.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knopers8

knopers8 commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Deal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner
@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Barthelemy @knopers8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.