GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Extract trend generation out of TrendingTask by knopers8 · Pull Request #2706 · AliceO2Group/QualityControl

Conversation

@knopers8

@knopers8 knopers8 commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

To allow for reimplementation of TrendingTask as a late task, but keeping both for backwards-compatibility. As a bonus, we are able to test the trending functionalities much easier and wider.

Needed for QC-1362.

Assisted by Claude Sonnet 5.5

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@knopers8
knopers8 requested review from Barthelemy and justonedev1 as code owners November 11, 2026 13:06
@knopers8

knopers8 commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

@Barthelemy the code preserves the same functionality and for the most part, it was just moved from one place to another, so I don't think there is a need for a very thorough review of the logic, but just a check whether you agree with how the refactor is done.

I validated (hopefully) all the functionalities by running TrendingTask with different customization options and inspecting the generated objects.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@knopers8
knopers8 force-pushed the trending-lt branch from 9629fc2 to c605235 Compare November 11, 2026 13:12
knopers8 added 2 commits November 11, 2026 14:13
@knopers8
Extract trend generation out of TrendingTask
c605235 
To allow for reimplementation of TrendingTask as a late task, but keeping
both for backwards-compatibility. As a bonus, we are able to test
the trending functionalities much easier and wider.

Needed for QC-1362.
@knopers8
clang-format
b9a9f84

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner
@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@knopers8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.