GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tilePairClient: add support for more parameters and multi-file support by RussTorres · Pull Request #151 · AllenInstitute/render-python

Conversation

@RussTorres

@RussTorres RussTorres commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

resolves #150 and related to saalfeldlab/render#113

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RussTorres
tilePairClient: add support for more parameters and multi-file support
7c95f5b
fcollman
fcollman reviewed Nov 24, 2020
View reviewed changes
Comment thread renderapi/client/client_calls.py
for jsonfile in jsonfiles:
os.remove(jsonfile)

return ((jsondata, jsonfiles) if return_jsonfiles and return_jsondata

@fcollman fcollman Nov 24, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the case of delete_json does it make sense to return paths to files that aren't there?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@RussTorres RussTorres Nov 24, 2020

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practically speaking I don't think so, but since return_jsonfiles defaults to False it seems like we should keep the outputs explicit. Returning an empty list (i.e. just return the files you can expect to find) might work too, and I don't have a strong preference.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RussTorres
tilePairClient: better support for non-null outjson inputs
92733b2
fcollman
fcollman approved these changes Nov 24, 2020
View reviewed changes
@RussTorres
RussTorres merged commit 4f0137d into AllenInstitute:develop Jan 25, 2021
@RussTorres RussTorres mentioned this pull request Jan 29, 2021
Tilepair client, cannot find json file #150
Closed
@RussTorres RussTorres mentioned this pull request Jul 11, 2022
Develop -> master #160
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcollman fcollman fcollman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@RussTorres @fcollman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.