GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pointmatch: add functions for fast and deep copy by RussTorres · Pull Request #155 · AllenInstitute/render-python

Conversation

@RussTorres

@RussTorres RussTorres commented Feb 12, 2021

Copy link
Copy Markdown
Collaborator

This adds a function to "copy" pointmatch dictionaries such that changes to the match arrays of the original do not affect the copy.

As background for why this is useful, BigFetA has use cases where it transforms pointmatches in-place. This becomes a problem when doing multiple-step in-memory alignment or trying to interrogate residuals. To be on the safe side I've been copying the matches before each step, which is very expensive on large alignments.

The test I added uses the same match objects (via copy/paste) as the integration test, but I am surprised to see that the format of the dictionaries doesn't match what I was seeing in real pointmatch collections, e.g.

"p": [[1, 2, 3], [1, 2, 3]] (pointmatch collection)
vs
"p": [[1, 1], [2, 2], [3, 3]] (test fixture)

This actually doesn't affect the way I have the copy implemented, but I'm not sure if this is a long-standing typo or something that changed without us noticing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
RussTorres added 2 commits February 12, 2021 14:54
@RussTorres
pointmatch: add functions for fast and deep copy
20d937e
@RussTorres
test_pointmatch: use six
d0947b2
fcollman
fcollman approved these changes Feb 15, 2021
View reviewed changes
@RussTorres RussTorres mentioned this pull request Feb 15, 2021
test_pointmatch: input dictionaries don't fit format #156
Open
@RussTorres
RussTorres merged commit 2404132 into develop Feb 15, 2021
@RussTorres
RussTorres deleted the copy_matches branch February 15, 2021 21:44
@RussTorres RussTorres mentioned this pull request Jul 11, 2022
Develop -> master #160
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcollman fcollman fcollman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@RussTorres @fcollman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.