GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Comment on Binaryen proposal · Issue #91 · AssemblyScript/binaryen.js

Comment on Binaryen proposal #91

New issue
Copy link
New issue
Copy link
Open
Open
Comment on Binaryen proposal#91
Copy link

Description

@ericvergnaud
ericvergnaud
opened on Jan 9, 2024
Issue body actions

Hi there,

to avoid observed gaps between the TypeScript in this repo and the underlying JavaScript in Binaryen repo, I have submitted a PR that moves the TypeScript source to the Binaryen repo and generates the JavaScript from it, thus ensuring a single source of truth.

The PR is here WebAssembly/binaryen#6192. (If approved, that PR would be followed by a corresponding PR in this repo, adjusting for the change of source of truth for TypeScript)

It would be great if you could comment on that PR rapidly such that the Binaryen team can reach a decision on whether or not to accept the PR.

Reacted by Chris Harvey

Activity

  1. dcodeIO commented on Jan 14, 2024

    @dcodeIO
    dcodeIO
    on Jan 14, 2024
    Member
    More actions

    I do like the idea of replacing the JS plus separate typings with TS plus generated typings. I'd probably go even further and also generate the API docs from tsc's type info and respective comments while on it. Or even further, and generate all of it while also guaranteeing that the C++, C and JS APIs are in sync.

  2. ericvergnaud commented on Jan 14, 2024

    @ericvergnaud
    ericvergnaud
    on Jan 14, 2024
    ContributorAuthor
    More actions

    Following a counter PR WebAssembly/binaryen#6224, I've opened a discussion here: WebAssembly/binaryen#6225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.