GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [Implement] Buffer#inspect by jtenner · Pull Request #15 · AssemblyScript/node

Conversation

@jtenner

@jtenner jtenner commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jtenner
[Implement] Buffer#concat (todo: fix tlsf problem)
99b14a8
@jtenner
jtenner requested a review from dcodeIO July 22, 2019 18:17
@jtenner jtenner self-assigned this Jul 22, 2019
@jtenner jtenner changed the title [Implement] Buffer#concat (todo: fix tlsf problem) [Implement] Buffer#inspect (todo: fix tlsf problem) Jul 22, 2019
jtenner added 2 commits July 23, 2019 09:44
@jtenner
[Fix] Clean up inspect implementation
8812172
@jtenner
[Fix] Edge case when length = 0, todo: more optimization
01d079b
@jtenner

jtenner commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

@dcodeIO I think this could probably be optimized further but I've hit my limit. Any thoughts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jtenner added 2 commits July 23, 2019 14:31
@jtenner
[Chore] switch to global
10a5c54
@jtenner
[Chore] Merge master
fe0cf50
@jtenner jtenner changed the title [Implement] Buffer#inspect (todo: fix tlsf problem) [Implement] Buffer#inspect Jul 23, 2019
@jtenner
[Optimize] memory.copy parameters with global strings
f418fd0
@jtenner jtenner added the enhancement New feature or request label Jul 23, 2019
@jtenner
[Merge] master, use Hex encoding method
cea7473
@jtenner

jtenner commented Aug 1, 2019

Copy link
Copy Markdown
Contributor Author

This method is the reason why I created the charsFromByte() method. Now we can re-use it here in the .inspect() method.

All set for review @dcodeIO
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MaxGraey
MaxGraey reviewed Aug 6, 2019
View reviewed changes
Comment thread assembly/buffer/index.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
jtenner added 5 commits August 6, 2019 10:51
@jtenner
Merge branch 'master' into inspect
e5f6e4a
@jtenner
[Fix] switch to hex
628562c
@jtenner
[Fix] types merge problem
b956d5e
@jtenner
[fix] example
e8afe85
@jtenner
[chore] remove unecessary comment
b9ed343
MaxGraey
MaxGraey reviewed Aug 6, 2019
View reviewed changes
Comment thread assembly/buffer/index.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
jtenner added 5 commits August 6, 2019 11:54
@jtenner
[fix] nit remove parenthesis
a5579cb
@jtenner
[fix] remove type annotation
11cc4d3
@jtenner
[test] use create convenience method instead
a00145c
@jtenner
[fix] switch to known constant
ef7e34e
@jtenner
[fix] add BUFFER_INSPECT_HEADER_BYTE_LEN constant
5fe8a7f
@jtenner

jtenner commented Mar 13, 2020

Copy link
Copy Markdown
Contributor Author

Using the new __aspectReflectAs() api, we can log(new ArrayBuffer()) with the inspect output just like node.js outputs Buffers. Will have to revisit this later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxGraey MaxGraey MaxGraey left review comments
@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jtenner jtenner

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jtenner @MaxGraey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.