GeezerVison is showing github.com — [Implement] Buffer.compare by jtenner · Pull Request #7 · AssemblyScript/node
Conversation
jtenner
commented
Jul 19, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Notes:
- this function works really nicely with
memory.compare()
Currently, the compiler doesn't like using static functions as function parameters (Will open an issue in the AssemblyScript repo)
ERROR AS218: Cannot access method 'compare' without calling it as it requires 'this' to be set.
actual.sort(Buffer.compare);
~~~~~~~~~~~~~~
in tests/buffer.spec.ts(60,16)
Edit:
Switching to static readonly function expression causes this to compile
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
With the static function fix, everything seems to look nice. Thoughts? @dcodeIO
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
TODO: Implement Buffer#compare.
TODO: Return 1, 0, or -1
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
dcodeIO
Awaiting requested review from dcodeIO
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.