GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: serialize account database migrations by Shubham-Padkonde · Pull Request #607 · Backblaze/b2-sdk-python

Conversation

@Shubham-Padkonde

@Shubham-Padkonde Shubham-Padkonde commented Sep 27, 2026

Copy link
Copy Markdown

Fixes #232.

Two SDK instances can both observe a pending account-database migration before either applies it. Their subsequent transactions then duplicate the same schema change (or insert duplicate migration markers). Acquire SQLite's write reservation with BEGIN IMMEDIATE and recheck update_done inside that transaction before applying commands. The migration and its completion marker still commit or roll back together.

The regression synchronizes two independent connections after both observe the pending migration, covering versions 1–6 and checking that stored account data survives. All six cases fail without the fix. A separate test verifies rollback after invalid SQL and a successful retry. Includes a changelog fragment.

Validation:

  • Linux Python 3.12.13 full unit/doctest suites: v3 776 passed / 63 skipped; v2 783 / 66; v1 858 / 97; v0 701 / 374.
  • Serial v3 coverage run: 776 passed, 63 skipped, 76% overall coverage. An earlier parallel coverage run stalled and was interrupted; the serial run completed.
  • Ruff check across source/tests/noxfile, format check across source/tests, static test and dependency-license check passed. The untouched noxfile.py has an existing format-check failure.
  • Windows Python 3.13: 748 passed, 79 skipped, 12 symlink tests failed with WinError 1314. The same 12 fail on the unchanged production code; all migration regressions pass with the fix.
  • No live B2 integration or macOS validation performed.

Prepared and tested with Codex assistance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Shubham-Padkonde
fix: serialize account database migrations
e186138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lock migrations in SqliteAccountInfo

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@Shubham-Padkonde
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.