GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — refactor(graphs): make BaseGraph::id return &str and align usages by prestoalvarez · Pull Request #398 · BitVM/BitVM

Conversation

prestoalvarez commented Oct 9, 2025

Copy link

Copy Markdown

Summary

Switch BaseGraph::id to return &str instead of &String for a more idiomatic and flexible API. No runtime logic changes.

Changes

Update trait method in bridge/src/graphs/base.rs to fn id(&self) -> &str.
Align implementations in bridge/src/graphs/peg_in.rs and bridge/src/graphs/peg_out.rs.
Adjust call sites and type usages to work with &str where applicable.

Motivation

Prefer string slices over owned String in signatures.
Decouple API from a concrete container, improve ergonomics and composability.
Avoid unnecessary allocations/copies at call sites.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

prestoalvarez added 3 commits

October 9, 2025 21:47


          Update base.rs

d8ffad8


          Update peg_in.rs

9f4e8a1


          Update peg_out.rs

3d2eb59

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.