GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Adding Join page for group by mmilkin · Pull Request #10 · BostonPython/studygroup

This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@mmilkin

@mmilkin mmilkin commented Jul 21, 2014

Copy link
Copy Markdown

Adding Join action for a group.

Now with notifications

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mmilkin added 5 commits July 20, 2014 16:30
@mmilkin
adding group
3d05d95
@mmilkin
adding membership
6c4a4f5
@mmilkin
adding tests
5231b03
@mmilkin
adding messaging on group join
fb91bbd
@mmilkin
no leader no message
35b05bc
@mmilkin

mmilkin commented Aug 4, 2014

Copy link
Copy Markdown
Author

Added the beginning of the notification (this is now done through meetup, if we want to collect emails we could send emails ourselves. For now this is synchronous, not sure if we want to complexity of celery or async.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmilkin mmilkin mentioned this pull request Aug 4, 2014
When someone joins a Group, the Group Managers should be notified. #5
Open
@mmilkin
adding support for a list of leaders
86ab638
@nedbat

nedbat commented Aug 14, 2014

Copy link
Copy Markdown
Member

I didn't want to collect emails, it feels like a barrier to people participating, so notifying through Meetup is the right way to do it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmilkin

mmilkin commented Aug 14, 2014

Copy link
Copy Markdown
Author

I agree, we could query meetup for emails using the api but that might be intrusive.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedbat

nedbat commented Aug 14, 2014

Copy link
Copy Markdown
Member

Well, meetup won't give out emails, there's no API to do that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mmilkin mmilkin closed this Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mmilkin @nedbat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.