GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add proposed status to study groups by armooo · Pull Request #8 · BostonPython/studygroup

This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@armooo

@armooo armooo commented Apr 17, 2014

Copy link
Copy Markdown
Contributor

This changes adds a StudyGroupStatus model and a FK from StudyGroup. It also hides StudyGroups in the proposed status from normal users.

We don't have a DB migration system setup so you need to drop and recreate the database to pick up the schema changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
armooo added 3 commits April 16, 2014 19:31
@armooo
Normalise quotes to single quotes
c8ac5bc
@armooo
Add group statuses
f2ff675 
Add statueses to groups and default new groups to have the status of
proposed.
@armooo
Filter study groups based on proposed
8bd455a 
Do not list proposed groups to non-admins. Also respond with a 404 to
groups that are proposed to non-admins.
@armooo

armooo commented Apr 18, 2014

Copy link
Copy Markdown
Contributor Author

I am going to rebase this on the migration branch and add a migration.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedbat

nedbat commented Apr 18, 2014

Copy link
Copy Markdown
Member

I don't understand why we need a new table. Surely a status column on the group table would be enough?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@armooo @nedbat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.