GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Add numeric framerate limit input by Riqqqque · Pull Request #3632 · CaffeineMC/sodium ConversationCloses #3556. Adds a numeric input for the framerate limit so exact caps can be entered instead of being limited to 10 FPS slider steps. Changes:
The standalone addon this was ported from is Unlicense. Validation:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
douira
requested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you don't have a suggestion for changes to the API to accomodate a second type of integer option, I can also do that myself during merge.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
douira
requested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've pushed some changes to this branch to clean up some things, faster than going back and forth here.
output.mp4
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
douira
requested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to work now but I'm somewhat confused why we need
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Yea, we need this! I play with VRR and i would like to have my framerate capped exactly at 177fps. I currently use a mod which makes the slider go by steps of 1 instead of 10. But having an input box built in to sodium itself, sounds awesome. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
9af86f1 to
c0a05a4
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It appears that tab navigation between options is broken on this branch.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Fixed the tab navigation issue. Normal option controls were returning their own focus path even while already focused, so Tab kept selecting the same option. The fallback now only returns the control when it is not already focused; controls with children still use parent traversal. Checked with:
Commit: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
1db98b9 to
dbeb597
Compare
|
Rebased onto current Checked with:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Replace the framerate slider with a numeric input for custom FPS caps
There was an error while loading. Please reload this page.