GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add ruff.toml with default config plus numpy docstrings by galenseilis · Pull Request #263 · CiwPython/Ciw

Conversation

@galenseilis

@galenseilis galenseilis commented Apr 9, 2025

Copy link
Copy Markdown
Contributor
  • Adding a ruff.toml.
  • The rule set can be changed, but for the moment I want with the default given in the Ruff documentation with one added difference.
  • The added difference is setting Ruff to use NumPy's pydocstyle rather than Googles or PEP257.
    • Discussion here seems to support this choice of convention.

After there are some agreed rules for Ruff, I will start making non-breaking formatting changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@galenseilis
add ruff.toml with default config plus numpy docstrings
776eab7
@galenseilis

galenseilis commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

#217
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geraintpalmer

geraintpalmer commented Jun 4, 2025

Copy link
Copy Markdown
Member

Hi @galenseilis Can you explain a bit more about what this is please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@galenseilis

galenseilis commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

Hi @galenseilis Can you explain a bit more about what this is please?

Absolutely. Ruff is a linting and formatting tool. What the ruff.toml specifies is configuration for when the ruff tool is used within the directory of this Python project.

  • Here is the general documentation for ruff.
  • There is also this introduction post you can review.

If you agree that we can use Ruff for working with Ciw, then we can also review and revise the proposed config in this PR.

Let me know what you think.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@galenseilis

galenseilis commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@geraintpalmer did you have any more questions or concerns about this that you would like to discuss?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@galenseilis @geraintpalmer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.