GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add support for custom rules by kgmt0 · Pull Request #250 · ClearURLs/Addon

Conversation

kgmt0 commented Aug 25, 2022

Copy link

Copy Markdown

This adds a textarea in the settings page that can be used to enter custom rules in the same format as data.json. These rules are applied on top of the ones from data.json.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

warptozero, cristsr, farOverNinethousand, Banaanae, FoxRefire, SunsetTechuila, rugabunda, puksh, and NautaSquid reacted with thumbs up emoji

All reactions

👍 9 reactions

kgmt0 added 2 commits

August 26, 2022 03:38


          Add support for custom rules

adb399f

This adds a textarea in the settings page that can be used to enter
custom rules in the same format as data.json. These rules are applied on
top of the ones from data.json.


          Make start.getKeys() in clearurls.js ignore method names

5dcb14e

start.getKeys() was using a for...in loop to iterate over fields in the
given object, meaning that methods names (e.g. getOrDefault()) get
included in the iteration as well. This causes erroneous entries to be
added the global list of providers. Fix this by using Object.keys() to
extract field names and iterate over that instead.

sonarqubecloud Bot commented Aug 25, 2022

Copy link

Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TheCrazyMax commented Nov 10, 2023

Copy link

Copy Markdown

That's exactly what I was looking for in the extension options, thinking this was a base feature.
Is there any plan to merge this ? :)

rugabunda reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

inson1 commented Dec 15, 2023

Copy link

Copy Markdown

@KevinRoebert ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

WolfganP commented Dec 15, 2023

Copy link

Copy Markdown

Good idea. It will also help to submit improved rules to the core set, as advanced users may test the rules easier.

inson1, farOverNinethousand, Acelya-9028, mtsz-pl, and rugabunda reacted with thumbs up emoji

All reactions

👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Acelya-9028 commented Jul 9, 2024

Copy link

Copy Markdown

Please merge it :s

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mtsz-pl commented Nov 18, 2024

Copy link

Copy Markdown

@KevinRoebert this PR exists for more than two years now, could you please merge it or decline, so that we all know how things are with this feature?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rugabunda commented May 9, 2025

Copy link

Copy Markdown

Add this feature please

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Neustradamus commented Aug 2, 2025

Copy link

Copy Markdown

@kgmt0: Can you create a PR on Gitlab too?

https://gitlab.com/ClearURLs

If it is not merged, I think it is the moment to fork this project.

Acelya-9028 and NautaSquid reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kgmt0 commented Aug 6, 2025

Copy link

Copy Markdown

Author

@kgmt0: Can you create a PR on Gitlab too?
* https://gitlab.com/ClearURLs

https://gitlab.com/ClearURLs/ClearUrls/-/merge_requests/111

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.