GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Whitelist by Banaanae · Pull Request #372 · ClearURLs/Addon

Conversation

@Banaanae

@Banaanae Banaanae commented Jun 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This PR adds a whitelist button, which then allows users to prevent sites from being filtered
Whitelisting is now pretty much finished, only the issue with subdomains being treated like separate sites remain, just waiting on maintainer's opinions on adding another library. (If current behaviour is also like there could be an option in settings)
This PR has only been tested on firefox, if chrome users could test it be greatly appreciated

  • Make whitelist for full domain (currently if www.example.com is whitelisted, example.com isn't. This could be considered intentional, but it would still break cases like www.example.com calling assets.example.com)
  • Allow users to unwhitelist whitelisted sites (only possible via full reset atm, would replace Whitelist Site with Remove From Whitelist when viewing a whitelisted page)
    • Update button after user presses it
    • Make button spam resistant
  • List whitelisted sites in settings
  • Fix styling
  • Support for ip addresses? (Might already be working, untested)
  • Whitelist sites on per rule basis (meaning exempt a site from one rule but not another, requested in Feature request to be able to exclude websites #93, but might not be added in this PR)

Once done this will close #93 and its many duplicates

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deathtrip, SunsetTechuila, LorenDB, bitA23187, aplotor, wintergew, and BartlomiejSkwira reacted with thumbs up emoji o-data, kadykov, J-Emil-P, banditByte, azz147, Speedy2662, LorenDB, and Rekunan reacted with hooray emoji Go-rom reacted with eyes emoji
All reactions
  • 👍 7 reactions
  • 🎉 8 reactions
  • 👀 1 reaction
Banaanae added 2 commits June 25, 2024 16:15
@Banaanae
first commit for adding whitelist
858863d 
base functionality
@Banaanae
allowing editing of whitelisted sites in settings
56ccb0c 
just show data in a text input
no fancy formatting needed!
@Banaanae

Banaanae commented Jun 25, 2024

Copy link
Copy Markdown
Author

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Banaanae
handle url better; fix saving when edited
af9cbe5 
... via settings
@Banaanae

Banaanae commented Jun 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Using a library like tld.js could fix the first issue
Alternatively we could parse the psl ourselves, but seems redundant because of above lib
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Banaanae
fix styling; allow removing of sites
19d3448 
still needs to update after press
@Banaanae

Banaanae commented Jun 26, 2024

Copy link
Copy Markdown
Author

image
image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Banaanae
Fix updating whitelist button
5dbb116 
- Button now reflects whitelist status instantly
- Fixed bug where only last site whitelisted displayed properly
- No longer breaks when spammed
- Removed test code
@Banaanae
Banaanae marked this pull request as ready for review June 26, 2024 23:42
@Banaanae

Banaanae commented Jun 26, 2024

Copy link
Copy Markdown
Author

I'm marking this as ready for review, before merging a few things need to happen

  • Chrome testing
  • Decide on if tld.js should be used to fix first task

Not going to do the last task, a bit above my skill level
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Banaanae Banaanae mentioned this pull request Jun 26, 2024
Feature request to be able to exclude websites #93
Open
@Banaanae

Banaanae commented Jul 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

@KevinRoebert do you have any plans to merge this?
If you'd rather me create this on gitlab I have finally got my account unblocked :)
I know you are in the process of rewriting this extension, (with whitelisting being included), but it has been some time since that announcement, (maybe merge this in the mean time, and then replace my stuff with your fix?). This has been one of the most requested features.
Danielwsx64 and BartlomiejSkwira reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KevinRoebert KevinRoebert self-assigned this Jul 9, 2024
@KevinRoebert
KevinRoebert self-requested a review July 9, 2024 08:18
@rdslw

rdslw commented Jul 14, 2024

Copy link
Copy Markdown

Would be great to have it, as currently clearurls breaks amazon sorting, resulting in user not being able to select any other sorting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KevinRoebert

KevinRoebert commented Jul 14, 2024

Copy link
Copy Markdown
Member

@Banaanae First of all, thank you for your contribution.

I am currently reviewing the code. It still needs some changes and also has a couple of bugs. I will make the changes directly and then merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KevinRoebert
KevinRoebert reviewed Jul 14, 2024
View reviewed changes
Comment thread clearurls.js
* Skip whitelisted sites
*/
for (const site of storage.whitelist) {
if (url.indexOf(site) != -1) {

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!==

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
siteFound = true
}
});
if (!siteFound) {

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap both cases

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
}
});
if (!siteFound) {
if (data.response.length != 0) {

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this If. It causes the button to retain the "btn-danger" class when a page is added and immediately removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
function: "getData",
params: ['whitelist']
}).then((data) => {
data.response.forEach(site => {

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be replaced by the following: let siteFound = data.response.some(site => currentSite.indexOf(site) !== -1);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
* @param {boolean} remove If true remove current site instead of adding
*/
function changeWhitelist(removeWl = false) {
if (removeWl != true) { // Handle click obj

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment is useless. It is better to pass the correct state in the onclick event

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
element.classList.replace('btn-danger', 'btn-primary')
}
element.textContent = translate('popup_html_configs_whitelist_button_add')
document.getElementById('whitelist_btn').onclick = changeWhitelist;

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass the desired state here: () => {changeWhitelist(true)}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
}).then((data) => {
let siteUrl = new URL(site)
let domain = siteUrl.hostname
if (removeWl == false) {

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap both cases

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread core_js/popup.js
if (removeWl == false) {
data.response.push(domain)
} else {
data.response = data.response.filter(wlSite => wlSite != domain)

@KevinRoebert KevinRoebert Jul 14, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsafe comparison, better !==

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KevinRoebert

KevinRoebert commented Jul 14, 2024

Copy link
Copy Markdown
Member

https://gitlab.com/ClearURLs/ClearUrls/-/merge_requests/110
Source-Dom and banditByte reacted with rocket emoji
All reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Acleacius

Acleacius commented Sep 12, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Thanks for your work, just noticed as I was posting in the other thread about a new issue I found, unrelated to your fix.

I'm gonna quote my post as to not retype it, just thought if your actively working on it you might be interested. :)

New issue at least to me, when using Google Maps it keeps the url locked so Google can't zoom in and auto readjust
positioning. It also means many normal functions on Google Maps don't work such as clicking on a POI to get the popup
and all the information provided. Such as Hours of Operation, Crowd Size (haha) atm and Addresses.

Personally, I still use this mod BUT it's really good to get a list of places and situations, so we can be aware to disable manually
as necessary.

Looking forward to trying your fixes! :D
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@junginlee82

junginlee82 commented Dec 30, 2024

Copy link
Copy Markdown

Eagerly awaiting this! (Or please kindly point to where I can download this build!)
banditByte, kaubu, tcelestino, jwfuller, AncientYears, and BartlomiejSkwira reacted with thumbs up emoji
All reactions
  • 👍 6 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Speedy2662 Speedy2662 mentioned this pull request Jan 7, 2025
Seems to be interfering with Google Sheets in Firefox #387
Closed
@Serubin

Serubin commented Jan 9, 2025

Copy link
Copy Markdown

Bumping this - tons of sites are broken, most critical the google drive suite. This really needs more attention
banditByte, jcap, gkrawiec, jwfuller, alexmbright, VasilisThePikachu, strathos, Famaku, javijjah, AncientYears, and 3 more reacted with thumbs up emoji
All reactions
  • 👍 13 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KMohZaid KMohZaid mentioned this pull request Feb 16, 2025
Add exclusion by domain or in global expections #353
Open
@KMohZaid

KMohZaid commented Feb 16, 2025

Copy link
Copy Markdown

i missed this PR and related issue and made new PR #383
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LaDorade

LaDorade commented Jul 29, 2025

Copy link
Copy Markdown

any news about that ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Neustradamus

Neustradamus commented Aug 2, 2025

Copy link
Copy Markdown

@Banaanae: Can you create a PR on Gitlab too?

  • https://gitlab.com/ClearURLs

If it is not merged, I think it is the moment to fork this project.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Neustradamus Neustradamus mentioned this pull request Aug 2, 2025
add exclusion setting for domains ( related issue #353 ) #383
Open
@Banaanae

Banaanae commented Aug 2, 2025

Copy link
Copy Markdown
Author

@Neustradamus this was done in #372 (comment)
I don't think it makes a difference if I made another one
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GarLuna86
GarLuna86 approved these changes Sep 26, 2025
View reviewed changes

@GarLuna86 GarLuna86 left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un cordial saludo. Solicito de su apoyo para impedir el redireccionamiento de enlaces URLs. Aún soy nuevo en programación y en Github. De favor realizó una solicitud de extracción para poder contribuir y poder llevar a cabo con eficiencia mi privacidad. Gracias.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pseudomonas pseudomonas mentioned this pull request Nov 12, 2025
ClearURLs breaks bol.com ClearURLs/Rules#283
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevinRoebert KevinRoebert KevinRoebert left review comments
+1 more reviewer
@GarLuna86 GarLuna86 GarLuna86 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@KevinRoebert KevinRoebert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request to be able to exclude websites

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@Banaanae @rdslw @KevinRoebert @Acleacius @junginlee82 @Serubin @KMohZaid @LaDorade @Neustradamus @GarLuna86
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.