GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(#509): add disable on current site control by rbalogic · Pull Request #516 · ClearURLs/Addon

Conversation

@rbalogic

@rbalogic rbalogic commented May 23, 2026

Copy link
Copy Markdown

Summary

This PR introduces a per-site disable control, allowing users to quickly turn ClearURLs off for the current site when it breaks a workflow.

It adds a popup action to toggle ClearURLs on the active site, persists the disabled hostnames in extension storage, and bypasses URL cleaning for requests and history updates originating from those sites.

Problem

Currently, ClearURLs can only be toggled globally. When a specific site breaks, users have no fast escape hatch other than disabling the entire add-on and waiting for a upstream fix. This makes site-specific regressions much more disruptive than necessary.

Changes

  • Storage & State: Added a persisted disabledDomains list in extension storage.
  • Background Script: Added shared hostname helpers and tab URL tracking.
  • Popup UI: Added a new Site section featuring:
    • Current site status.
    • A toggle button (Disable on this site / Enable on this site).
  • Logic Bypasses: - Bypasses webRequest URL cleaning when the current site is disabled.
    • Bypasses history API cleaning for disabled sites.
  • i18n: Added English localization strings for the new popup UI elements.

Behavior

  • Disabling a site strictly affects that specific site's hostname.
  • The add-on remains active globally for all other sites.
  • Users can easily re-enable the site using the same popup control.

Notes

  • This PR is intentionally scoped to the per-site disable feature to address issue Add option to disable addon on current domain #509.
  • It does not add an allowlist-only mode or a “clean only on selected sites” feature, as those would require separate product and implementation design.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vvv, elwinschmitz, and Fluboxer reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@rbalogic
fix(ClearURLs#509): add disable on current site control
5694635
@rbalogic
rbalogic force-pushed the feat/509-disable-on-current-domain branch from 6296426 to 5694635 Compare May 23, 2026 13:44
@rbalogic rbalogic mentioned this pull request May 23, 2026
Add option to disable addon on current domain #509
Open
@rbalogic
fix: sort alphabetically
b176f41
@sonarqubecloud

sonarqubecloud Bot commented May 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
26 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rbalogic

rbalogic commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi @KevinRoebert 👋 Can you review this PR when you have some time? Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dsmvwllr

dsmvwllr commented Jul 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Any ETA for a merge and maybe another for release?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fabian42

Fabian42 commented Aug 19, 2026

Copy link
Copy Markdown

Confirmed, works! 👍
To install, I downloaded the zip from this branch, unpacked it, repacked it without a top-level folder (select all files inside and pack that) and then used "Install add-on from file", which only worked because I already had the setup for local extensions: Firefox developer edition and about:config with xpinstall.signatures.required=false.

rbalogic and dsmvwllr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dsmvwllr

dsmvwllr commented Aug 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

A note for more safely testing extensions:

  1. Download the extension sources
  2. Update the manifest.json with a new value for browser_specific_settings.gecko.id to a fake email address or a UUID (a UUID needs to be wrapped in braces)
  3. In Firefox, disable the original extension and then navigate to about:debugging#/runtime/this-firefox
  4. Click the "Load Temporary Add-on..." button and select the edited manifest.json from the downloaded files
  5. When testing is complete, you can remove the temporary extension or just quit Firefox and it's gone (and changing the ID of the temp extension won't mess with the "real" install of it when you go back to using it)
  6. You can also test temporary extensions using web-ext, but that's too involved for a post like this.

So, no need to modify the xpinstall.signatures.required preference, which is enabled for good reason and could be easy for some to forget to re-enable.

At any rate, thanks for the update and testing. I'm happy to have a nice improvement to look forward to.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rbalogic @dsmvwllr @Fabian42
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.