GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add hints by nberger · Pull Request #11 · ClojureBA/reagent-tutorial

Conversation

@nberger

@nberger nberger commented Jun 2, 2018

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nberger
nberger requested a review from facundoolano June 2, 2018 01:56
nberger added 2 commits June 1, 2018 23:25
@nberger
Add mechanism to show a hint on each example
0353749 
Adds an example hint, in spanish as we are aiming at translating to spanish for the tutorial
@nberger
Actually keep everything in english for consistency
37accf3
@nberger
nberger force-pushed the add-hints branch from 13db63b to 37accf3 Compare June 2, 2018 02:25
facundoolano
facundoolano reviewed Jun 2, 2018
View reviewed changes
Comment thread demo/reagentdemo/common.cljs
[:div.simple-demo [comp]]
[comp])])])
[comp])])
(when hint

@facundoolano facundoolano Jun 2, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could extract these toggles into a helper component

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
facundoolano
facundoolano approved these changes Jun 2, 2018
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facundoolano facundoolano facundoolano approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nberger @facundoolano
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.