GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add inline completion (ghost text) coordination layer by anxkhn · Pull Request #375 · CodeEditApp/CodeEditSourceEditor

Conversation

anxkhn commented Jun 30, 2026

Copy link

Copy Markdown

Description

Adds an inline completion (ghost text) coordination layer to CodeEditSourceEditor, built on the inline suggestion rendering primitive in CodeEditTextView. It gives the editor a provider-agnostic way to request, show, accept, cycle, and dismiss inline AI suggestions (the GitHub Copilot UI pattern), without any host having to re-implement the lifecycle.

What's added:

InlineCompletionDelegate: a @MainActor protocol a host conforms to. inlineCompletionsRequested(textView:cursorPosition:) async -> [InlineCompletionItem] returns suggestions; optional inlineCompletionDidShow/Accept/Dismiss hooks report lifecycle.
InlineCompletionItem: the suggestion model (insert text and the range it applies to).
InlineCompletionTriggerModel plus TextViewController methods: requestInlineSuggestion() (debounced), setInlineSuggestions(_:selectedIndex:), acceptInlineSuggestion(), dismissInlineSuggestion(), selectNext/PreviousInlineSuggestion().

Behavior:

Requests are debounced and skipped while the completion popup is visible, so ghost text and the popup never appear at the same time.
Tab accepts when a suggestion is active; the accepted text is inserted via the text view.
Moving the cursor or editing dismisses the active ghost text.
Ghost text is rendered by the CodeEditTextView overlay primitive and never mutates text storage until the suggestion is explicitly accepted.

Related Issues

closes Inline completion (ghost text) coordination layer #374
Depends on Add inline suggestion (ghost text) rendering primitive CodeEditTextView#125 (this PR uses the new TextView.setInlineSuggestion / clearInlineSuggestion API). The CodeEditTextView dependency in Package.swift should be bumped to the release that includes it before this is merged.

Checklist

I read and understood the contributing guide as well as the code of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code

Screenshots

This is the coordination layer; the user-visible ghost text is shown by the app-level integration in CodeEdit. Behavior here is covered by unit tests.

Testing

xcodebuild -scheme CodeEditSourceEditor -destination "platform=macOS,name=My Mac" clean test: the full suite passes, including the new InlineCompletionTests suite (request/show, accept, dismiss, cycling, Tab-accept gating, and ghost-text clearing on cursor move and edit), built against the CodeEditTextView change in [chore]: Update CodeEditLanguages to 0.1.9 #125.
SwiftLint: 0 violations (strict) on all changed files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          feat: add inline completion (ghost text) provider and Tab-accept

8a1f971

Add the inline completion plumbing that drives the CodeEditTextView ghost
text primitive. A delegate provides completion items, the controller
renders the selected item as ghost text anchored at the caret, and
keyboard shortcuts accept, dismiss, and cycle through items.

- InlineCompletionItem: Identifiable item holding insertText and the range
  it replaces on acceptance (an empty range is a pure insertion).
- InlineCompletionDelegate: @mainactor protocol to request items and observe
  the show, accept, and dismiss lifecycle, with default empty impls.
- InlineCompletionTriggerModel: requests after typing and clears stale ghost
  text, mirroring SuggestionTriggerCharacterModel.
- TextViewController+InlineCompletion: debounced single in-flight request,
  render, accept, dismiss, and next/previous cycling.
- Wire triggers and clears into didReplaceContentsIn and updateCursorPosition,
  and add Tab-accept, Escape-dismiss, and Option+]/[ cycling key handling.
- SourceEditor and TextViewController gain a weak inlineCompletionDelegate,
  forwarded exactly like completionDelegate.

This was referenced Jun 30, 2026

Native GitHub Copilot inline completions CodeEditApp/CodeEdit#2181

Open

Add native GitHub Copilot inline completions CodeEditApp/CodeEdit#2182

Draft

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inline completion (ghost text) coordination layer

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.